No feedback if OPML import contains no feeds or folders

[dbeniamine]

Hi,

I had troubles importing an .opml file into owncloud new application. After a while wondering why nothing was happening I realized that I was importing a wrong file which was not an opml file. Sadly Owncloud didn't tell me about my mistake.

David

[BernhardPosselt]

Method is here: https://github.com/owncloud/news/blob/master/js/service/OPMLParser.js#L60

We should validate it, and if needed throw an exception which is caught here:
https://github.com/owncloud/news/blob/master/js/controller/SettingsController.js#L77

Should we use an alert for showing the error message?

@cosenal @jancborchardt any ideas on how to show proper feedback?

[dbeniamine]

I haven't looked at the code, but when we provide a badly formatted .opml file Owncloud shows an error message near the import button, I guess it seems reasonable to show a "Bad file format" error at the same place.

[jancborchardt]

Yep, good suggestion. A slightly better error message could be »Wrong file format. Please choose an OPML file.«?

[BernhardPosselt]

Ok, after going through the issues I can not reproduce it. If I upload an invalid OPML file I'm getting: Error when importing: file does not contain valid OPML

[dbeniamine]

It happened to me while uploading a .gpx file (export.gpx, instead of export.opml) which occurs to be a correct xml file. I guess that New parses the xml correctly but does nothing as the file does not contain any opml entries.

There is an (almost) empty gpx file (renamed export.txt because of github limitations) with which the bug occurs.

I'm running News 6.1.1 over Owncloud 8.2.2 installed from the Owncloud repositories on a Debian stable with Apache 2.4.10, Php 5.6.17-0 and Mysql 5.5.47-0.

I hope this is enough info to reproduce the bug.

[BernhardPosselt]

Ok, so the solution is basically to show an error message if no feeds or folders are found

[dbeniamine]

I agree, but I guess there are two distinct errors:

• Bad file format (valid xml but no tag)
• No feeds or folder found (valid xml with tag but empty)

I think that those two errors are quite different: the first is a bad manipulation from the user, while the second might come from a BUG on the tool used to generate the OMPL export.

[BernhardPosselt]

Marking this as a junior bug because its very easy to fix and a low priority bug :)

Tips:
The parsedContent variable here: https://github.com/owncloud/news/blob/master/js/controller/SettingsController.js#L42

is a JavaScript object that has a list of feeds and folders:

{feeds: [], folders: []}

All that needs to be done is to test if both of them are of length 0 and then throw an exception (which will be caught here: https://github.com/owncloud/news/blob/master/js/controller/SettingsController.js#L76)

The error message also needs to be improved to reflect the additional erorr state: https://github.com/owncloud/news/blob/master/templates/part.settings.php#L97 by simply adding the additional failure cause or by adding a new type of error on the settings controller.

The JavaScript needs to be compiled using gulp, instructions are here https://github.com/owncloud/news/tree/master/js#javascript-development