Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Non-latin search is case sensitive #944

Closed
Loki3000 opened this issue Mar 24, 2016 · 5 comments
Closed

Non-latin search is case sensitive #944

Loki3000 opened this issue Mar 24, 2016 · 5 comments

Comments

@Loki3000
Copy link
Contributor

Explain the Problem

Search feeds with non-latin chars is case sensitive.

Steps to Reproduce

in search field type одного and hit Enter

Expected:

filter the entity

Одного из израильских генералов спросили, можно ли простить террориста?
На это он ответил:
— Бог простит. Наша задача организовать их встречу.

Actual:

Empty result

System Information

  • News app version: 7.1.2
  • ownCloud version: 9.0.0
  • PHP version: 7.0.4
  • Database and version: mysql 5.5.47
@BernhardPosselt
Copy link
Contributor

Feel free to submit a fix, I unfortunately can not test this very well on a Latin only keyboard. Relevant section should be here: https://github.com/owncloud/news/blob/master/db/itemmapper.php#L71

Solution is probably to replace strtolower with mb_strtolower, please try if this works and submit a pull request

@BernhardPosselt
Copy link
Contributor

Ah right, same issue here where it creates the index https://github.com/owncloud/news/blob/master/db/item.php#L219

@BernhardPosselt
Copy link
Contributor

You will need to readd the feed to check if it worked btw

@Loki3000
Copy link
Contributor Author

Thanks!
Now search works well.

@BernhardPosselt
Copy link
Contributor

Can you create a pull request to fix it for everyone ;D?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants