Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover all Webdav file operations #297

Closed
PVince81 opened this issue Aug 26, 2016 · 12 comments
Closed

Cover all Webdav file operations #297

PVince81 opened this issue Aug 26, 2016 · 12 comments

Comments

@PVince81
Copy link
Contributor

In integration tests, we don't cover all file operations yet, only a few like move and copy.

It would be good to complete the list and also possibly do it for both the old and the new endpoint. (too bad behat doesn't have a way to run the same test with different data)

@SergioBertolinSG

@SergioBertolinSG
Copy link
Contributor

Well we can simply duplicate tests changing the stament Given using dav path "remote.php/webdav"

@SergioBertolinSG
Copy link
Contributor

What is left here?

I am seeing:

  • Move operations in different situations
  • Copy operations in different situations
  • Propfinds
  • Creating new elements (upload)
  • Create new collections is implicit in tests
  • Deletion of files in different situations

Anything else needed?

@PVince81
Copy link
Contributor Author

Indeed, seems I can't think of anything else.

Maybe need to add cases where permissions are denied (already with move/copy)

@PVince81
Copy link
Contributor Author

  • upload+overwrite in non-chunked mode
  • upload+overwrite in chunked mode

Note that these could have special implications when dealing with encryption and could reveal issues like owncloud/core#26978 (comment)

@SergioBertolinSG
Copy link
Contributor

Deletion, in trashbin feature file can have more cases. Deleting a folder, shared folder and so on.

@phil-davis
Copy link
Contributor

See owncloud/core#32366 for some "current" review of webDAV acceptance test scenarios.

@patrickjahns
Copy link
Contributor

@PVince81 @DeepDiver1975
Are you able to provide input here, on what still needs coverage so we can schedule acceptance tests for it

@PVince81
Copy link
Contributor Author

PVince81 commented Aug 21, 2018

see issue #634

@PVince81
Copy link
Contributor Author

I think the above listed by Sergio are already nice to have a good base coverage.

Most important is likely the upload with and without chunking, with and without overwrite on old and new endpoint. We might already have coverage for this in the api upload tests.

@phil-davis
Copy link
Contributor

I added this to the next sprint backlog, just so that someone can quickly look if there are ideas here for test scenarios that do not exist yet. Then if easy, add scenarios. Or if there is a lot do do then mention it here.

@dpakach
Copy link
Contributor

dpakach commented Dec 11, 2019

Almost all of the operations are covered by API acceptance tests. The next step will be to add more tests to check the edge cases.

More tests that can be added to Webdav file operations

  1. Perform all the actions with using incorrect authentication/password - see issue Test with invalid authentication #632
  2. Perform all the file actions with another user's authentications. - see issue Test with invalid authentication #632
  3. Perform file actions on files that contains special characters - see issue Test file actions for a range of file/folder combinations #633
  4. Perform file actions on the files that are inside sub folders with several levels of depth - see issue Test file actions for a range of file/folder combinations #633

@phil-davis
Copy link
Contributor

The remaining things here have been put into separate issues. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants