Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acceptance tests for some sharing situations #339

Closed
SergioBertolinSG opened this issue Dec 20, 2016 · 11 comments
Closed

Add acceptance tests for some sharing situations #339

SergioBertolinSG opened this issue Dec 20, 2016 · 11 comments

Comments

@SergioBertolinSG
Copy link
Contributor

SergioBertolinSG commented Dec 20, 2016

Ref: owncloud/core#24053 (comment)

Copied here the comment table:

This is the behaviour in 9.1.2:

Alice's Activity Bob's Activity Alice's Trashbin Bob's Trashbin
Alice deletes file1.txt in Alice's share You deleted file1.txt Alice deleted file1.txt file1.txt -
Bob deletes file2.txt in Alice's share Bob deleted file2.txt You deleted file2.txt file2.txt file2.txt
Alice moves file3.txt out of Alice's share - - - -
Bob moves file4.txt out of Alice's share - - - -

This is what I would expect:

Alice's Activity Bob's Activity Alice's Trashbin Bob's Trashbin
Alice deletes file1.txt in Alice's share You deleted file1.txt Alice deleted file1.txt file1.txt -
Bob deletes file2.txt in Alice's share Bob deleted file2.txt You deleted file2.txt file2.txt file2.txt
Alice moves file3.txt out of Alice's share - - - -
Bob moves file4.txt out of Alice's share Bob removed file4.txt from share - file4.txt -
@SergioBertolinSG
Copy link
Contributor Author

SergioBertolinSG commented Dec 20, 2016

There is a core limitation here, trashbin files cannot be accessed via api or webdav yet:

owncloud/core#20047
owncloud/core#12543

@SergioBertolinSG
Copy link
Contributor Author

SergioBertolinSG commented Jun 5, 2017

This is unblocked now as trashbin feature uses the ajax calls from the ui. Not the best solution, but enough to continue.

@SergioBertolinSG SergioBertolinSG added this to the 10.0.3 milestone Jun 5, 2017
@PVince81
Copy link
Contributor

PVince81 commented Jul 3, 2017

assigning to you since you've been working on it @SergioBertolinSG

@SergioBertolinSG
Copy link
Contributor Author

Hmm I can add the trashbin part but not the activity as there are no tests about activity at all. Is that ok?

@PVince81
Copy link
Contributor

PVince81 commented Jul 4, 2017

fine by me.

note that the activity part hasn't been implemented anyway

@SergioBertolinSG
Copy link
Contributor Author

Does it have an API or some way to check what appears in the activity tab?

@PVince81
Copy link
Contributor

PVince81 commented Jul 4, 2017

yes... probably undocumented... need to check the network tab

@SergioBertolinSG SergioBertolinSG modified the milestones: planned, development Aug 1, 2017
@SergioBertolinSG
Copy link
Contributor Author

Yes, when requesting activity by the server I saw it was calling a public api.

It was documented here: https://github.com/owncloud/activity/blob/master/docs/endpoint-v2.md

@felixboehm felixboehm modified the milestone: planned Sep 4, 2017
@phil-davis phil-davis changed the title Add integration tests for some sharing situations Add acceptance tests for some sharing situations Aug 17, 2018
@phil-davis
Copy link
Contributor

There are acceptance tests in core apiTrashbin suite that check that files deleted in shares do end up in the trashbin.

@skshetry there do not seem to be test scenarios in the activity app that test activity messages when sharers and/or sharees delete and restore shared items in/out of the trashbin. Please check.

@skshetry
Copy link
Member

skshetry commented Jul 8, 2019

@phil-davis, here's the issue for that: owncloud/activity#747

@phil-davis
Copy link
Contributor

Activity-specific test issue has been made. Nothing left to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants