[FEATURE REQUEST] New background image for the login screen

[ChrisEdS]

Describe the solution you'd like

With the ownCloud Server 10.5 release we said goodbye to the satellite that was visible in the login screen. In the Android app it is still visible. To be in sync the picture should be changed there as well.

Steps taken

I have already prepared the new images in the following branch:
https://github.com/owncloud/android/tree/new-ci-images

Please note

What should be considered is the fact that the positioning of the new image should start from the lower right edge. The new CI image has design elements only in the left and right corner.

In portrait format you should see the following part of the design:

AC:

• Login view will include the new image
• Top drawer will include the new image

TASKS

• Research
• Create branch new_background_images
• Development tasks
  • Create util for matrix scaling
  • apply matrix scaling util for login and drawer image
  • add compatibility for whitelabel version
• Code review and apply changes requested
• Test background design with ownbranded version of the app
• Design test plan
• QA
• Merge branch new_background_images into master

PR

• Old: Add the new ci images we introduced with oC 10.5 #2996
• New: New background images #3023

[jesmrec]

Will include in 2.16.

Also, we have to change in the top side of the drawer where the satellite image is shown.

[ChrisEdS]

Also, we have to change in the top side of the drawer where the satellite image is shown.

I'm one step ahead. 👍

https://github.com/owncloud/android/blob/77e19f96c8bcd9d5dd65af4551bcf70666cb3888/owncloudApp/src/main/res/drawable-hdpi/drawer_header_background.png

But that image needs to be improved maybe.

[theScrabi]

Currently the app crashes on this branch. The stacktrace depics that the login button is null. Which can not be. This behaviour is not related to anything that the code does at the moment, which is weird and might required deeper investigation.

The scale view from bottom right is not working appropriately as well: https://github.com/owncloud/android/pull/2996/files#diff-64c334a87f1aea1fb0d3bcbc70d21e40d71ab4f51551665eec612117962f17b3

This function needs to be called every time the layout needs to be updated. This is required since we want the anchor point of the image to be on the bottom right of the screen and the image. Then we want to scale towards the top left. Either cropping the top part of the image or the left part of it. This needs to be done in order to ensure that 1. The image covers the whole screen, 2. the shapes on the bottom right are always visible.

However apart from crashing the this function is not even scaling appropriately. I'd like to test it on a device that allows to freely size the app screen like resizing windows. This can be done with software like android x86, or anbox on ubuntu.

Additionally we need to distinguish between branded and the regular application. This needs to be done since branded apps do not use this image, and so the scaling must fall back to center crop.

I think the easiest way to go here is to keep center crop scaling but design a background image for portrait mode. This way we can ensure that the shapes are always visible without having to do complex matrix transformation.

[abelgardep]

I think the easiest way to go here is to keep center crop scaling but design a background image for portrait mode. This way we can ensure that the shapes are always visible without having to do complex matrix transformation.

100% Agree. From my point of view we should not overcomplicate this issue. New images included in this commit are pretty wide and when we try to center them, those shapes are missing. An image for portrait mode will be centered automatically fixing the problem we have when trying to scale it starting from bottom right.

[theScrabi]

@ChrisEdS Maybe you can directly send us the SVG versions these can be shown more crisp on phones even with normal resolution ;)

[abelgardep]

Drawer	Login Portrait

Login Landscape

EDIT: Final background images.

@ChrisEdS @michaelstingl @theScrabi @jesmrec

[ChrisEdS]

How important are the shapes in login landscape mode? At the moment we lose them. If we want to add a new background image exclusively for landscape, we probably will need to ask for an additional image in oB for landscape.

I can provide the image. But what about branding? In ownBrander we only upload one picture.

[michaelstingl]

I can provide the image. But what about branding? In ownBrander we only upload one picture.

Yes, single-image-only for branding customers please. Vanilla-oC can have some extra eyecandy, similar as we do with the new-features-wizard.