Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update primary and accent colors #3034

Merged
merged 6 commits into from
Dec 18, 2020
Merged

Update primary and accent colors #3034

merged 6 commits into from
Dec 18, 2020

Conversation

abelgardep
Copy link
Contributor

@abelgardep abelgardep commented Dec 10, 2020

Continuation of #2991 Color inconsistency. Should follow this guideline

Old colors New colors
old_colors  new_colors
  • Update primary and accent color
  • Update icon background color. Old iteration: make adaptive icon based on png #2261
  • Multi-selection checkbox uses the old color, is an image, and it is not brandable. We should switch to a checkbox with accent color. (Should we move it to a new iteration?)

@theScrabi
Copy link
Contributor

theScrabi commented Dec 11, 2020

Here is the updated icon:

Old colors New colors
old_oc_icon icon

@abelgardep abelgardep marked this pull request as ready for review December 15, 2020 10:33
@jesmrec
Copy link
Collaborator

jesmrec commented Dec 17, 2020

Should the notification icon be re-done with the new colors?

https://github.com/owncloud/android/blob/master/owncloudApp/src/main/res/drawable-xhdpi/notification_icon.png

@abelgardep
Copy link
Contributor Author

Should the notification icon be re-done with the new colors?

https://github.com/owncloud/android/blob/master/owncloudApp/src/main/res/drawable-xhdpi/notification_icon.png

Good catch, i think so

@jesmrec
Copy link
Collaborator

jesmrec commented Dec 18, 2020

Notification icon updated. No much to test here, new values replace the older ones following the oC guidelines. Always open to new iterations.

Approved.

@abelgardep abelgardep merged commit 6d02bd2 into master Dec 18, 2020
@abelgardep abelgardep deleted the update_main_color branch December 18, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants