Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] 3.0 Beta.2 #3771

Closed
25 of 40 tasks
jesmrec opened this issue Oct 4, 2022 · 24 comments · Fixed by #3787
Closed
25 of 40 tasks

[RELEASE] 3.0 Beta.2 #3771

jesmrec opened this issue Oct 4, 2022 · 24 comments · Fixed by #3787
Assignees
Labels

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Oct 4, 2022

Will be released with P2 and P3 pending reports from Beta.1 as well as new reports and feedback.

List of issues, ordered by priority:

P1 (must in Beta.2)

P2 (must in oficial release)

P3 (nice to have)

To verify

TASKS:

  • [GIT] Create branch release/X.X.X in owncloud/android from new_arch/synchronization
  • [DEV] Update version number and name in build.gradle in owncloudApp module
  • [DIS] Add ReleaseNotes replacing emptyList with listOf and adding inside ReleaseNote() with String resources
  • [QA] Design Test plan
  • [QA] Regression Test plan
  • [DIS] Generate test bundle from release/X.X.X branch in owncloud/android
  • [GIT] Create and sign tag 'oc-android-X.X.X' in HEAD commit of release branch, in owncloud/android
  • [GIT] Create and sign tag 'Y.Y.Y' in HEAD commit of release branch, in owncloud/android-library
  • [DIS] Generate final bundle from signed commit in owncloud/android
  • [GIT] Merge branch release/X.X.X in owncloud/android, into master
  • [DIS] Upload & publish release bundle and changelog in Play Store
  • [DIS] Update screenshots and store listing, if needed, in Play Store
  • [GIT] Publish a new release in owncloud/android
  • [DIS] Create post in central.owncloud.org (Category:News + Tag:android)
  • [COM] Inform #updates and #marketing in internal chat
  • [DIS] Upload release APK and bundle to internal owncloud instance

BUGS & IMPROVEMENTS

@jesmrec jesmrec added the Release label Oct 4, 2022
@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(1) [P2] [FIXED]

  1. Browse to a folder that contains a huge amount of files (f.ex ~1000 files)
  2. Select all
  3. Select Remove -> Yes to remove from server, not only locally

Current: Spinner and waiter in the screen for a long time. App is blocked for the user.
Expected (master): App is not blocked while files are being deleted

Update:
Fixed in #3776

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(2) [P2] [FIXED]

  1. Download a txt file
  2. Select it in the list of files -> Remove -> Local only

Current: List of files is cleaned up and file name is set on the tool bar
Expected: File loses the green bagde of dowloaded and list of files in the screen

device-2022-10-21-122216.mp4

Update:
Fixed in #3785

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(3) [P3]

  1. Select a folder
  2. Select Copy
  3. Select as target folder, same folder as 1.

Current: error message is too long, and could not be read completely:

Screenshot 2022-08-19 at 13 45 51

Expected (master): message is reduced: It is not possible to copy a folder into a descendant

NOTE: same for move

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(4) [P3]

  1. Browse to folder Photos
  2. Select a file to upload inside
  3. Before submitting, remove the folder Photos in another client
  4. Submit the upload

Current: Photos folder is created again with the picture inside
Expected: Folder was deleted, so it should trigger a Folder error. Maybe the current behaviour is not too evil, open to discussion

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(5) [P3]

Open to discussion: when a bunch of files is uploaded and uploads run fast. it's difficult to check what's going on in the uploads view because items move up and down very fast in a non-readable way:

device-2022-08-18-145000.mp4

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(6) [P3]

  1. Set to upload a very big file
  2. When file is uploading, set to upload other files

Current: Pending files with the status Uploading, same as the file that is really being uploaded:

Screenshot 2022-08-29 at 13 51 04

Expected: different status. File uploading with Uploading and others with Waiting or similar

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(7) [p3] (improvement)

  1. Upload many files manually
  2. Remove device connection

Current: it may happen that the amount of enqueued files is very big. For example:

Screenshot 2022-08-31 at 15 07 51

Do you think it'd be interesting to add a Clear button to the enqueued? is it feasible to cancel works at that point?

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(8) [P2]

  1. Enter in an OAuth2 account
  2. In the server, remove the token
  3. In the app, download a file

Current: notification not clickable in snackbar
Expected: notification clickable to redirect to login view

master 3.0-beta.1
Screenshot_20221004_165248 Screenshot_20221004_164946

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(9) [P2] [FIXED]

  1. Click on a big previewable file (for example, a 30M big image)

Current: Progress bar is missing
Expected: Progress bar works

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(10) [P1]

  1. Download a text file, or set it as av. offline
  2. Go back to the list of files
  3. In server, modify the text file
  4. Open txt file in app

Current: download enqueued but old content displayed. By reopening the file, content is correct.
Expected: download done and new content displayed

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(11) [P1] [FIXED]

  1. Set a folder with subfolders in root as av. offline
  2. Move the folder to any other location
  3. Browse into the new location to see the av. offline folder

Current: app crashes:

2022-07-29 10:02:25.768 30687-30687/? E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.owncloud.android.debug, PID: 30687
    java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String com.owncloud.android.domain.files.model.OCFile.getStoragePath()' on a null object reference
        at com.owncloud.android.operations.SynchronizeFolderOperation.getFolderPath(SynchronizeFolderOperation.java:533)
        at com.owncloud.android.ui.errorhandling.ErrorMessageAdapter$Companion.getResultMessage(ErrorMessageAdapter.kt:183)
        at com.owncloud.android.ui.activity.FileActivity.onRemoteOperationFinish(FileActivity.java:275)
        at com.owncloud.android.services.OperationsService.lambda$dispatchResultToOperationListeners$0(OperationsService.java:487)
        at com.owncloud.android.services.OperationsService$$ExternalSyntheticLambda0.run(Unknown Source:6)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7870)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

Expected: no crash

NOTE: same behaviour by moving a subfolder from av. offline folder.

UPDATE:
After performing the big cleaning (#3765) this is not reproducible anymore.

3507daf

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(12) (improvement) [P3]

  1. Set a folder with many items inside as av. offline (so, the sync operation will take more time)

Current: The option Unset as av. offline is available in three dot menu while the folder is being synced.
Expected (current master): while folder is being synced, the option to Unset as av. offline is available on the top bar, so only one click is required to cancel sync:

Screenshot 2022-07-29 at 10 48 32

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(13) [P2]

Related to #3498

  1. Create a link on a pdf file
  2. Open Links tab
  3. Clink on the pdf file -> open details view
  4. Select Open with and open the file with an external app
  5. Go back to oC app

Current: Toolbar shows Shared by link in the details view

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(14) [P2]

  1. Select a file in file list
  2. Click on download or select av. offline option

Current: Sync badge is gone
Expected: Sync badge displayed

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(15) [P2]

  1. Open Details view of any file in the root folder
  2. Click on Share icon on the top
  3. Click on back arrow

Current: toolbar is not correct. It includes items of root folder instead of Details view
Expected: Details view items

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(16) [P2]

  1. Install v2.18.3 (or any version before Scoped Storage release)
  2. Add account
  3. Upload a very big file
  4. Before the upload ends, upgrade to current and run wizard
  5. Open uploads view

Current: upload stucked and never ends.
Expected: upload resumed and finished

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(17) [P1] [FIXED]

  1. Create a folder that contains 1000 files
  2. 3-dot-button -> Select All

Current: App stucked causing ANR
Expected: App not stucked

Update:
Fixed in #3776

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(18) [P2] [FIXED]

  1. User A shares an item with User B
  2. User B opens list of files

Current: User B sees the item in the list, but the sharing icon on the right is missing.
Expected: User B sees the item in the list and the sharing icon on the right.

Update:
Fixed in #3776

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 4, 2022

(19) [P2]

  1. Select a big file from the file list
  2. Click on the down arrow on the toolbar to download it

File starts to download (badge is gone as (14)), the way to check it is the Details view.

By cancelling the selection mode, and selecting the file again, the (x) to cancel is in the toolbar. By clicking the (x), the download is cancelled but the (x) remains in the toolbar.

Expected: Download and cancel buttons should be handled dinamically in toolbar, as in master. That means:

  • If user clicks on down arrow, the down arrow turns in (x) to cancel
  • If the download is running and user clicks on (x), (x) turns into down arrow again.

Sometimes, by clicking several times in (x) after cancelling, app crashes

Behaviour is correctly implemented in Details view

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 14, 2022

(20) [P2] [FIXED]

Comes from #2653

  1. User 1 shares a folder with User 2, with no editing permission
  2. User 2 uploads a file inside the restricted shared folder

Current: Correct error in uploads view, but notification shows a parameter %s:

Screenshot 2022-10-14 at 10 49 45

Expected: Readable message

Samsung A52
8f2d519d

Update:
Fixed in #3776

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 14, 2022

(21) [P3]

Comes from #2653

When a folder lacks of writing permission, FAB button could be hidden/disabled. In that way, we will avoid users to perform actions that will be banned.

Permissions available in property <oc:permissions> with the following values:

https://github.com/owncloud/client/blob/cedf72825bc0db8e3c147958a9382ee5b411d9ea/src/common/remotepermissions.h#L42-L54

Samsung A52
8f2d519d

@abelgardep
Copy link
Contributor

abelgardep commented Oct 27, 2022

(22) [P2] [FIXED]

Current behavior:
When we change the sort method in the file list, and enter into images gallery mode, the images shown do not respect the file list sorting.

Expected behavior:
Gallery mode uses the same sorting method as the user selected for file list

@jesmrec
Copy link
Collaborator Author

jesmrec commented Oct 27, 2022

(23) [P1] [FIXED]

  1. Install app from scratch in debug mode
  2. Click on Settings -> logging to check that logging feature is enabled and log file was created
  3. Go again to login view and login in a browser account (OAuth2 / OIDC).
  4. When login is completed, go to Settings -> Logging -> Log files

Current: empty
Expected: log file with logs there

Samsung A51 Android 12
7c8f2fef7

Update:
Fixed in #3785

@JuancaG05 JuancaG05 linked a pull request Nov 2, 2022 that will close this issue
@JuancaG05 JuancaG05 changed the title [RELEASE] 3.0-Beta.2 [RELEASE] 3.0 Beta.2 Nov 2, 2022
@jesmrec jesmrec mentioned this issue Nov 3, 2022
65 tasks
@jesmrec
Copy link
Collaborator Author

jesmrec commented Nov 3, 2022

Moving forward to 3.0 -> #3724

@jesmrec jesmrec closed this as completed Nov 3, 2022
@jesmrec jesmrec removed the Sprint label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants