-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] New UI for "Manage accounts" view #4410
base: master
Are you sure you want to change the base?
Conversation
277df42
to
2d78b9e
Compare
Modified too:
The aim of the last 2 points is to centralize all the accounts management functionalities in the new dialog |
…y and with a nice UX
…d set account when changing context
c8c4e08
to
be124fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions here @JuancaG05
owncloudApp/src/main/java/com/owncloud/android/presentation/accounts/ManageAccountsAdapter.kt
Outdated
Show resolved
Hide resolved
...App/src/main/java/com/owncloud/android/presentation/accounts/ManageAccountsDialogFragment.kt
Show resolved
Hide resolved
...App/src/main/java/com/owncloud/android/presentation/accounts/ManageAccountsDialogFragment.kt
Show resolved
Hide resolved
...App/src/main/java/com/owncloud/android/presentation/accounts/ManageAccountsDialogFragment.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ready for QA!
(1)
Current: app crashes. This is the stacktrace:
Expected: no crash Android 11, Pixel 2 |
…crash when rotating the screen
@jesmrec (1) should be fixed now |
Related Issues
App: #4312
ReleaseNotesViewModel.kt
creating a newReleaseNote()
with String resources (if required)QA