Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] New UI for "Manage accounts" view #4312

Closed
18 tasks done
JuancaG05 opened this issue Feb 13, 2024 · 6 comments · Fixed by #4410
Closed
18 tasks done

[FEATURE REQUEST] New UI for "Manage accounts" view #4312

JuancaG05 opened this issue Feb 13, 2024 · 6 comments · Fixed by #4410

Comments

@JuancaG05
Copy link
Collaborator

JuancaG05 commented Feb 13, 2024

EPIC:

Currently, the Manage accounts view looks like this:

This is a little bit outdated in terms of design, and shows a pretty empty screen unless you have several accounts. The aim here is to move this view to a dialog showing the same info, just like modern apps that follow the Material Design standards are doing lately:

Play Store Gmail Maps
play_store gmail maps

This implies changing the click listener of the avatar in the top bar, that will open this new dialog instead of going to the current screen, which will be deleted.

In addition, we'll remove the second menu of the drawer menu, which shows redundant options for managing accounts (adding an account, a link to the manage accounts screen and the other accounts), so that everything related to managing accounts is centralized in just 1 place. The click listener of the avatar in the drawer menu could be changed as well to open the new dialog.

Past proposals:

More proposals welcome!

TASKS

  • Research (if needed)
  • Create branch feature/new_ui_manage_accounts
  • Development tasks
    • Design mockups
    • Switch between accounts
    • Add a new account functionality
    • Clean account local storage functionality
    • suscribeToViewModels function
    • Hide the main dialog when you click on the remove account button
    • Refresh the file list when a new account is added
    • Remove second menu of the drawer menu, mini avatars and all the related stuff
    • Remove AccountsManagementActivity and its related tests
    • Implement unit tests (if needed)
    • Add feature to Release Notes (if required)
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/new_ui_manage_accounts into master
@joragua
Copy link
Collaborator

joragua commented May 2, 2024

I've designed two different mockups related with manage accounts view.

  • The first option looks like Google apps for example Gmail, Maps, Play Store, etc..
  • The second one has the same structure than legacy but in this case is a dialog and not a new view.
First Option Second Option
first_mockup second_mockup

In case you have more accounts linked with your device, both mockups look like this:

First Option (Multi account) Second Option (Multi account)
first_mockup_multi second_mockup_multi

@JuancaG05 @Aitorbp @jesmrec @tbsbdr Take a look if you can and share your opinions about this 😃

@jesmrec
Copy link
Collaborator

jesmrec commented May 3, 2024

In case of multiaccount, the "clean" and "delete" options are not clearly attached to the account. The compacted version (on the right) likes me the most. I know that they are mockups to make ourselves an idea, but i miss some beautifiers there.

@JuancaG05
Copy link
Collaborator Author

For a first iteration, I'd go for the second option. That is, keeping the current design but in a dialog instead of a new screen. Technically, it will be easier as well 😄

@joragua
Copy link
Collaborator

joragua commented May 7, 2024

After first iteration, I've redesigned the second option and that is the result:

@tbsbdr
Copy link

tbsbdr commented May 7, 2024

Thumbs up 👍 lets go, looks very good!

Summay of what we just discussed in addition:
Improvement for the future:

  • Problem: the brush icon is not very intuitiv, its not self-explaining.
  • Possible Solution:
    • show text next to the icon
    • maybe within an collapsible or dedicated dialog/drawer or alike

@joragua
Copy link
Collaborator

joragua commented May 24, 2024

WORK TO DO:

  • Hide the main dialog when you click on remove account button. If you confirm, you have to see files of the remaining account. Also, if you click on cancel option the main dialog would appear again.
  • Refresh the file list when a new account is added
  • suscribeToViewModels function

@JuancaG05 JuancaG05 self-assigned this Jun 5, 2024
@Aitorbp Aitorbp removed the Sprint label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants