-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get rid of jQuery UI #22
Comments
besides the dialog we also use a timepicker that requires jQuery UI. @raghunayyar @jancborchardt Do you know of any good alternatives? |
Can we simply use that part of jQuery UI? Or is the whole lib always needed? cc @owncloud/designers do you know of any modern good timepicker library which also work on mobile? |
It requires jQuery UI core (whatever that is) |
the jQuery UI dialogs are completely gone by now. The only thing left are the date and the time picker. |
The core issue was rescheduled to ownCloud 9.1 This leaves us plenty of time here. |
Awesome, I will find an ng replacement for them this weekend. |
Moving to 1.4, which will probably be our release to support 9.1 |
@jancborchardt What are the plans on the nextcloud side to drop jQuery UI? |
Let’s see where we still use it:
Anything else I forgot? I would say we should get rid of it step by step. We can use individual aspects of it if we want, but maybe it is better to use the relevant components from Bootstrap instead as we already do with tipsy/tooltip.js |
It's still used as a fallback, when notifications app is not enabled. |
Instead of that as fallback, could we use the notification up top? @nickvergessen |
We can talk about whether and how to change the layout. If it requires heavier changes, it's likely that it would slip to Nc 12. Anyway, the calendar repo is not the best place to track this… |
@blizzz see nextcloud/server#1090 for the server issue |
related to owncloud/core#18739
The text was updated successfully, but these errors were encountered: