Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of jQuery UI #22

Open
georgehrke opened this issue Sep 5, 2015 · 13 comments
Open

get rid of jQuery UI #22

georgehrke opened this issue Sep 5, 2015 · 13 comments

Comments

@georgehrke
Copy link
Contributor

related to owncloud/core#18739

@georgehrke georgehrke added this to the Rework - Sprint 3 milestone Sep 5, 2015
@raghunayyar raghunayyar modified the milestones: Maybe some day, Rework - Sprint 3 Oct 29, 2015
@georgehrke georgehrke modified the milestones: ownCloud 9.0, Maybe some day Nov 20, 2015
@georgehrke
Copy link
Contributor Author

besides the dialog we also use a timepicker that requires jQuery UI.

@raghunayyar @jancborchardt Do you know of any good alternatives?

@jancborchardt
Copy link
Member

Can we simply use that part of jQuery UI? Or is the whole lib always needed?

cc @owncloud/designers do you know of any modern good timepicker library which also work on mobile?

@georgehrke
Copy link
Contributor Author

Can we simply use that part of jQuery UI? Or is the whole lib always needed?

It requires jQuery UI core (whatever that is)
https://github.com/owncloud/calendar-rework/blob/master/js/vendor/jquery-timepicker/README.md#requirements

@georgehrke georgehrke modified the milestones: Beta 2, Version 1.0 Feb 9, 2016
@georgehrke
Copy link
Contributor Author

the jQuery UI dialogs are completely gone by now. The only thing left are the date and the time picker.

@georgehrke
Copy link
Contributor Author

The core issue was rescheduled to ownCloud 9.1 This leaves us plenty of time here.
Postponing here as well.

@georgehrke georgehrke modified the milestones: Version 1.3, Beta 2 Feb 17, 2016
@raghunayyar
Copy link
Member

Awesome, I will find an ng replacement for them this weekend.

@raghunayyar raghunayyar self-assigned this Feb 19, 2016
@georgehrke georgehrke modified the milestones: 1.4, 1.3-next May 10, 2016
@georgehrke
Copy link
Contributor Author

Moving to 1.4, which will probably be our release to support 9.1

@georgehrke georgehrke modified the milestones: 1.5, 1.4 May 12, 2016
@georgehrke georgehrke modified the milestones: 1.5 (ownCloud 9.1), 1.4-next Jun 9, 2016
@georgehrke
Copy link
Contributor Author

@jancborchardt What are the plans on the nextcloud side to drop jQuery UI?

@georgehrke georgehrke modified the milestones: 1.7, 1.5-next Aug 14, 2016
@jancborchardt
Copy link
Member

Let’s see where we still use it:

  • LDAP settings: we can move away from the tab-based layout now that the settings are split into individual pages. cc @blizzz
  • The modal for the filepicker. Maybe we can just use that part.
  • The modal for accepting remote shares: Moved to the notifications area. cc @nickvergessen @schiessle
  • The Calendar app here.

Anything else I forgot? I would say we should get rid of it step by step. We can use individual aspects of it if we want, but maybe it is better to use the relevant components from Bootstrap instead as we already do with tipsy/tooltip.js

@nickvergessen
Copy link
Contributor

The modal for accepting remote shares

It's still used as a fallback, when notifications app is not enabled.

@jancborchardt
Copy link
Member

Instead of that as fallback, could we use the notification up top? @nickvergessen

@blizzz
Copy link

blizzz commented Aug 26, 2016

LDAP settings: we can move away from the tab-based layout now that the settings are split into individual pages. cc @blizzz

We can talk about whether and how to change the layout. If it requires heavier changes, it's likely that it would slip to Nc 12. Anyway, the calendar repo is not the best place to track this…

@jancborchardt
Copy link
Member

@blizzz see nextcloud/server#1090 for the server issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants