Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notification with most recent version built from official release sources #10537

Closed
2 tasks done
hcsch opened this issue Feb 26, 2023 · 2 comments · Fixed by #10542
Closed
2 tasks done

Update notification with most recent version built from official release sources #10537

hcsch opened this issue Feb 26, 2023 · 2 comments · Fixed by #10542

Comments

@hcsch
Copy link

hcsch commented Feb 26, 2023

Pre-submission Checks

  • I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the bug

When launching the ownCloud client build from the most recent sources, the client displays an update notification stating that a new version (exactly equal to that which was build) is available. The "Updates" section in the "Settings" tab also notifies the user of this supposedly newer version.

Expected behavior

If the client was built from the most recent source release, no update notification should be displayed and the "Settings" tab "Updates" section should not say that a new version is available with the exact same version and build number.

Steps to reproduce the issue

  1. Open ownCloud client
  2. Observe update notification being displayed
  3. Open "Settings" tab
  4. Scroll to "Updates" section
  5. Observe notice about newer version being available with same version identifiers

Screenshots

Screenshot from 2023-02-27 00-43-09
Screenshot from 2023-02-27 00-51-25
Screenshot from 2023-02-27 00-49-13

Logs

No response

Client version number

ownCloud 3.2.0 718af2
Libraries Qt 5.15.8, OpenSSL 3.0.8 7 Feb 2023
Using virtual files plugin: suffix
nixos-6.1.12

Desktop environment (Linux only)

NixOS 23.05 (nixpkgs unstable) with GNOME 43.2

Client package version and origin (Linux only)

Installed from https://download.owncloud.com/desktop/ownCloud/stable/3.2.0.10193/source/ownCloud-3.2.0.10193.tar.xz

Installation path (Windows only)

No response

Server information

No response

Additional context

This is probably also one of the main use cases for the "skipUpdateCheck" option described in #5814 (comment). I've also had this issue with Arch builds

@hcsch hcsch added the type:bug label Feb 26, 2023
@TheOneRing
Copy link
Member

I'd recommend to build the client with "-DWITH_AUTO_UPDATER=OFF".
For 4.0 the parameter will default to off.

TheOneRing added a commit that referenced this issue Feb 28, 2023
The auto updater is only relevant for us and for customers using the updater.
Linux packagers are not interested in notifications regarding our latests release
during the client runtime.

Fixes: #10537
@TheOneRing TheOneRing added this to the 4.0 milestone Feb 28, 2023
TheOneRing added a commit that referenced this issue Feb 28, 2023
The auto updater is only relevant for us and for customers using the updater.
Linux packagers are not interested in notifications regarding our latests release
during the client runtime.

Fixes: #10537
@amrita-shrestha amrita-shrestha self-assigned this Mar 22, 2023
@amrita-shrestha
Copy link
Contributor

Tested with ownCloud 4.0.0.10476-daily20230322 [bb5d97] (Ubuntu 22.04 )
Screenshot from 2023-03-22 11-37-41

Expected: ✔️ no update available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants