[OS X] Yosemite "Dark Mode" menubar icon stays black on dark background

[StrangeNoises]

OSX Yosemite has a "dark mode" for the user interface, in which the menubar background goes from light grey to dark grey and the text and most menubar app icons are white.

Owncloud with monochrome icons selected doesn't adapt to this. The icon stays very dark grey, rendering it almost invisible on the dark background.

(Obviously no background-colour awareness either when colour icons selected, but at least visibility isn't an issue then.)

Desired behaviour: Awareness of the configured foreground and background colours in the menubar in Yosemite, and changing the colour or inverting the palette of the monochrome icon to match. FWIW the newest Viscosity (1.5.1) does invert the palette as you'd expect when using its new default icons, so it's not just Apple's own components that know how and when to do it. :)

I tried restarting it, in case it only picks up the colours on startup, but it didn't help. (In fact, upgraded belatedly from 1.6.2 to 1.6.3 - that didn't help either.)

Screenshot shows the problem. You're in good company of course, if you check out the icon of the app next to the Owncloud one. ;-)

I assure you the owncloud icon is there, in the middle, a very slightly lighter grey than its background.

[dragotin]

@jancborchardt , @danimo what can we do?

[jancborchardt]

Design-wise, when OS X is in dark mode (or the background is darker than 50% grey), the monochrome icon should switch from dark to light. The icons are already there.

This is a very similar issue to what already happens on existing OS X versions when clicking on the icon to expand the tray menu: #1730

Not sure if we/Qt can sense that though. Would certainly be good to have proper compatibility with the new OS X, and also make the icon look good when the menu is expanded.

[danimo]

@guruz There is no API for dark mode afaics.The icon is expected to be automatically convertible. This makes it a Qt issue.

[mrflix]

These are ways how to detect it in Objectiv-C if that helps: if its an image template mode should be used: http://indiestack.com/2014/10/yosemites-dark-mode/ and here how to detect dark mode: http://stackoverflow.com/questions/25379525/how-to-detect-dark-mode-in-yosemite-to-change-the-status-bar-menu-icon

[ventolin]

If it's too difficult to detect, perhaps we could get a checkbox in the preferences next to the other one, "Use Dark Mode Monochrome Icons" or something like that?

[johannesjh]

Technically, I found that Apple recommends to create this effect (of different icon colors depending on menubar color) using so-called "template images" - whatever that is.

Compare Apple's Human Interface Guidelines:

Use a template image to represent a menu bar extra. In General system preferences, users can change the menu bar (and Dock) to a dark appearance. If you don’t use a template image to represent your menu bar extras, they might not look good in both menu bar appearances.

Note:
Maybe these "template images" also fix the problem that the current owncloud icon is too dark (full black instead of approximately #454545) if shown in a bright menubar. See how the owncloud icon is darker than all others in the following screenshot:

[Razer0123]

Any news on that? i would be glad to help if i can

[petercampanelli]

@johannesjh Is correct. The icon needs to be set as a template. This blog post may help.

[iamso]

I'm using dark mode on OS X 10.10 and I'm always having trouble finding the icon in the menubar. Would really be nice to have the white icon. As mentioned above owncloud isn't the only app still having this issue. How soon can we expect this to be fixed?

[leipert]

Corresponding qt bug report here:
https://bugreports.qt.io/browse/QTBUG-42109

[AlexanderWillner]

Seems that the corresponding change in QT has been merged in July 2015: https://codereview.qt-project.org/#/c/115120/

[chesterdkat]

Just checked with Version 2.0.2rc1 (build 2790) and this bug is still present...

THANK YOU!

[guruz]

@AlexanderWillner thanks for digging this patch out.. we will need to modify our ownCloud-Qt for OS X

@dragotin @danimo

[StrangeNoises]

confused now because I thought this had been fixed. Is for me anyway in 2.0.1 release. Is it a regression in 2.0.2 builds?

It does sometimes go completely invisible until prodded in some way, but only on my multi-monitor setup, that I've seen, and it's pretty rare it does that now.

edit: Looks like my "does sometimes go completely invisible" issue is #3918. Yes I get that occasionally, but is different issue from this one surely, unless the one has caused the other.

[svkurowski]

I fixed this in [https://github.com//pull/2393](this pull request), which got merged. However my solution did not use OSX's template images because the functionality was not available in Qt. According to https://bugreports.qt.io/browse/QTBUG-42109, it is now available. At the moment I don't have the time to work on this, maybe someone else is interested in making the tray icons use template images on OSX?

[StrangeNoises]

ah right, the difference between a fix-for-now and a proper fix. ;-)

[guruz]

Tested with Qt 5.6, it works properly there. Now we just need to switch the OS X builds to Qt 5.6 -> #3449

[StrangeNoises]

It's looked fine for me for some time. Thought there was just some desire to do it a more 'proper' way or something! 😀

Sent from my iPhone

On 26 Apr 2016, at 09:05, Miguel Castro notifications@github.com wrote:

@StrangeNoises may you test again ¿? In case it fails please repone

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

[chesterdkat]

Fixed for me for at least several weeks or more. THANKS!

On Apr 26, 2016, at 04:20, Rachel Greenham notifications@github.com wrote:

It's looked fine for me for some time. Thought there was just some desire to do it a more 'proper' way or something! 😀

Sent from my iPhone

On 26 Apr 2016, at 09:05, Miguel Castro notifications@github.com wrote:

@StrangeNoises may you test again ¿? In case it fails please repone

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub