-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop Sync Confirmation when New Folders Added (Confirm feature) #3148
Comments
Yes, that's definitely what is desired (and currently missing). On the pop-up: I am not sure if this the best way of communicating with a user. I would personally hate this (especially if that would then block the client application from other activity). I would guess it would make for a far better user experience to have a notification (and also maybe an special icon in the tray) and then a list of shared folders waiting for acceptance in a separate tab of the settings menu of the client. Or having that integrated in a smart way with the existing "Choose What To Sync" dialog (which would then need to handle the logic of excluding by default newly created folders). The latter might be too confusing though with existing functionality of Choose What To Sync. |
@jancborchardt thoughts? |
A case should also be considered of missing information on the folder size of external mounted storage (I believe it is not always possible to provide this, or the information may be inaccurate). |
Yes, I would also go for a notification instead of a popup. I missed that in the proposal. But that was also what I originally suggested in Nürnberg (and @dragotin heavily argued »no no no notification« ;) And yes, the notification should then lead to the settings dialog and the activity tab, where pending shares should be shown up top. |
Great idea! Also would love to have a reverse - if someone deletes shared folder, you may opt to keep a local copy. Again, one can filter major events like modifications of over 50% of files. Essentially, whenever modification to local content is pushed by OTHER USER it would be great to have a confirmation. |
@alexpyattaev that’s a different topic though. Focus is on accepting shares here. |
Updating: Acceptance criteria:
|
@jancborchardt There is not enough in your face for a user to know how to decide to sync something - if it is not synced by default, and just sits in the activity list, it will get overlooked by a lot of users. I added that a notification comes up every 15 minutes as long as there are decisions to be made about what to sync or not. AND, once a sync is decided, what does one do then? |
@jancborchardt |
What do we do until the user decides? I hope we are able to ignore the directory until a decision was made, since otherwise we would have to stop the sync for the whole sync connection, which is probably not what we want... |
@MTRichards good stuff, only two things:
@dragotin yeah, the folder should be ignored until the user decides. That is basically it being unchecked in selective sync. |
We discovered a problem: In our PROPFIND requests which we use to discover the remote tree on the server, we do not get the size information for directories:
That is because that caused too much load on the server. @DeepDiver1975 what do you think, can we query for the size for dirs now? |
Here is Matt's last update comment comment with checkboxes for what's already done: Acceptance criteria:
|
Here is a screenshot on the UI as it looks now In that screenshot one can see that the TODO: Show a notification popup near the system tray (I assume that this is meant by "notification" in the acceptence criteria). And put an item for them in the "Activity" tab. Also TODO: add all the settings. @jancborchardt: in which part of the settings dialog should those option go? |
Also would it not make sens to have this feature activated for every folder instead of just for shared folder? (Currently it is only done for shared folder bigger than the threshold) |
Please, we need to remove the [Add Folder] thing. It's very confusing, I bet people will think they can create a new remote folder using that. Better would be to have a proper button next or underneath the delete button on top. Saying: Add Sync connection or similar... @jancborchardt |
"Also would it not make sense to have this feature activated for every folder instead of just for shared folder?" |
Looking at the code, those 2 edge cases (a) and (b) are handled nicely. |
Issue #3148 Implement the tray notification as specified. Unfortunately, the tray notification cannot be clicked
UPDATE:
|
@MTRichards seriously? Even when you created it yourself? That sounds a bit weird and definitely something which should be a setting or a branding option. |
…This should definitely apply to ANY top level shared folder – even if I create it. I may create/share a folder on one device, but I don’t want that to automatically get pushed out to each of my devices. Either you create a situation where I have to rush to every device and tell it “nevermind, don’t sync this new folder!”, or where I can go at my leisure to each device to say, “Yes, do sync this new content locally”. I much prefer the latter, and it works for my users. On notifications: a one-time pop-up (that should be acknowledged in order to disappear) is sufficient. If we can’t require an acknowledgement, then a blinky icon in the task bar should be used. |
@jancborchardt Yes. We get a ton of feedback on this option, particularly when working with 1) large files, or 2) external storage of any kind. See @phil-davis above, I think it is a quite good articulation of the value. @Lbryson-lifesize too. Maybe we should look at making this part of the install wizard, where the default is 100MB (is this too low?). Not too thrilled about adding installation steps. Some points:
|
"I may create/share a folder on one device, but I don’t want that to automatically get pushed out to each of my devices." |
This is looking great and addresses a number of issues raised by a wide range of users and managers in our organization. We have many users using ownCloud to transport large video files from remote locations to edit staff in our office as well as numerous other large shares of various kinds. The ability for users to veto a sync that is unexpectedly large, whether they own the folder (because someone dumped a huge file in there) or something was shared with them (a software repository for support personnel for example full of isos and dmgs) will be very welcome. |
One add: |
“I think we should up the default from 100MB to 500MB please.” I’d favor more conservative settings rather than opening it up so much. More importantly, make it as easy as possible for administrators to push out sane defaults (e.g. through registry settings or such), which the user may then override. …then it does not matter what the owncloud client-install defaults are, I can override it by default as an administrator; then the user can override that, if they know what they’re doing. |
@Dianafg76 Please always set needs info when you're stuck. Thanks! |
Yes, ideally they should. I have created a new issue for this: #3612 I am closing this issue, but please continue to test and report bugs as new issues. |
@ogoffart Many thanks!! |
So... what about the comment from @lbryson?
Is there another issue tracking this administrative capability or did I miss something? I whole-heartedly agree that the admin should have some power here. |
As a user, I want the desktop client to ask me if I want to sync a folder that was newly shared with me to the device I am using so that I do not fill my computer up with all of the files from a network drive or sharepoint instance when it is shared with me.
Acceptance criteria:
The text was updated successfully, but these errors were encountered: