Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old-style shadow effect from app icon #3693

Closed
jancborchardt opened this issue Aug 28, 2015 · 12 comments
Closed

Remove old-style shadow effect from app icon #3693

jancborchardt opened this issue Aug 28, 2015 · 12 comments
Assignees
@danimo
Labels
Design & UX type:bug
Milestone
2.0.2

Comments

@jancborchardt
Copy link
Member

@ogoffart @guruz can you let me know where the icon is stored? Then I will edit it and open a pull request.
@jancborchardt jancborchardt added this to the 2.0.1-next milestone Aug 28, 2015
@tomneedham
Copy link
Member

screen shot 2015-08-28 at 14 13 43

@ogoffart
Copy link
Contributor

ogoffart commented Sep 1, 2015

The png icons are in the theme/colored directory. But i don't know where the original svg is.

@ogoffart
Copy link
Contributor

ogoffart commented Sep 1, 2015

Apparently, they were made by Achim Geissel

@jancborchardt
Copy link
Member Author

Yeah, I’ll mail him.

@jancborchardt
Copy link
Member Author

Or basically just do it manually. Which sizes are necessary?

@ogoffart
Copy link
Contributor

ogoffart commented Sep 3, 2015

all the sizes in that folder.

@danimo
Copy link
Contributor

danimo commented Sep 10, 2015

@jancborchardt I'm mailing with achim already. Is he aware what this issue is about?

@jancborchardt
Copy link
Member Author

@danimo I guess if he takes a look at it or the icon (see @tomneedham's screenshot) then he will know what is meant, yes. Thank you!

@danimo danimo assigned danimo and unassigned jancborchardt Sep 10, 2015
danimo pushed a commit that referenced this issue Sep 10, 2015
Remove shadow from ownCloud icon
593ad20 
Fixes #3693
@danimo
Copy link
Contributor

danimo commented Sep 10, 2015

Testable with tomorrows' nightly builds.

@danimo danimo added the ReadyToTest QA, please validate the fix/enhancement label Sep 10, 2015
@jancborchardt
Copy link
Member Author

Great, thanks!

@Dianafg76 Dianafg76 added approved by QA and removed ReadyToTest QA, please validate the fix/enhancement labels Sep 15, 2015
@Dianafg76
Copy link

I tested this issue, and now no shading effect appears from app icon
Desktop v ownCloud Testpilot Edition-2.0.2.2715-nightly20150915.pkg
Closed

@jancborchardt
Copy link
Member Author

Awesome, thanks to Achim and @danimo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danimo danimo

Labels
Design & UX type:bug
Projects
None yet
Milestone
2.0.2
Development

No branches or pull requests
5 participants
@tomneedham @jancborchardt @ogoffart @danimo @Dianafg76