Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.2.0] Upload progress bar displays confusing values for filesize and number of files #4856

Closed
michaelstingl opened this issue May 17, 2016 · 18 comments
Closed

[2.2.0] Upload progress bar displays confusing values for filesize and number of files #4856

michaelstingl opened this issue May 17, 2016 · 18 comments
Assignees
@ckamm
Labels
blue-ticket ReadyToTest QA, please validate the fix/enhancement
Milestone
2.2.1

Comments

@michaelstingl
Copy link
Contributor

upload-progress-error

Expected behaviour

If I upload one 26MB file, the upload progress bar should display exactly "file 1 of 1" and "X MB of 26MB"

Actual behaviour

The 2.2.0 client shows wrong values. (see animation)

It looks like the client sums up the filesizes and number of files of all files that already exist in my account.

Steps to reproduce

  1. Initial sync download of 25 items with 60MB in total
  2. upload one 26 MB file with sync client ==> "X MB of 82 MB, file 25 of 25"
  3. upload one more 26 MB file with sync client ==> "X MB of 107 MB, file 26 of 26"
  4. upload one more 26 MB file with sync client ==> "X MB of 132 MB, file 27 of 27"

Server configuration

Operating system:
Debian

Web server:
Apache

Database:
SQLite

PHP version:
5

ownCloud version:
9.0.2

Storage backend:
local storage

Client configuration

Client version:
ownCloud-2.2.0.3358.pkg

Operating system:
Mac OS X 10.11.1

OS language:
English

Installation path of client:
/Applications/owncloud.app

@dragotin What happens here? Maybe related: #4832

00005496
@dragotin dragotin added this to the 2.2.1-current milestone May 18, 2016
@guruz
Copy link
Contributor

guruz commented May 18, 2016

@michaelstingl There is no "Show package contents" in the right-mouse-button menu of that file on your desktop?

@michaelstingl
Copy link
Contributor Author

@guruz No, the ownCloud-2.2.0.3358.pkg from our website is one compressed file, not a Mac OS X bundle.

@guruz
Copy link
Contributor

guruz commented May 18, 2016

Similar #4832

FYI @enoch85

@enoch85
Copy link
Member

enoch85 commented May 18, 2016 •
edited
Loading

@guruz Yes, I saw this issue before, and I can confirm this as well.

Client
Windows 2.2.0

@ogoffart ogoffart modified the milestones: 2.2.1, 2.3.0 May 19, 2016
@Daimonion1980 Daimonion1980 mentioned this issue May 19, 2016
Closed
@ckamm ckamm self-assigned this May 20, 2016
ckamm added a commit to ckamm/owncloud-client that referenced this issue May 20, 2016
@ckamm
Progress info: Reset between syncs owncloud#4856
33b502e
@ckamm
Copy link
Contributor

ckamm commented May 20, 2016

Pull request: #4872

jturcotte pushed a commit that referenced this issue May 20, 2016
@ckamm @jturcotte
Progress info: Reset between syncs #4856 (PR #4872)
c6794cd
@dragotin dragotin added the ReadyToTest QA, please validate the fix/enhancement label May 20, 2016
@ckamm ckamm mentioned this issue May 23, 2016
Closed
@frank9999
Copy link

This issue seems to be partially fixed. The counter seems to reset after uploads and doesn't sum everything together, which is good.
However the counter still starts with a random number (possibly failed uploads?).

For example:
If I upload 1 file, it says uploading 11 of 11 files.
If I upload 2 files, it says uploading 11 of 12 files.

On another test machine:
If I upload 1 file, it says uploading 5 of 5 files.
If I upload 2 files, it says uploading 5 of 6 files.

@michaelstingl
Copy link
Contributor Author

@frank9999 Thank you for your feedback!

@mcastroSG
Copy link

@frank9999 which build are you using for testing ¿?

It´s working fine for me with:

ClientOS: W10
Client Version: 2.2.1-nightly20160523 (build 6108)

Build for Windows

ClientOS : OS X El capitán 10.11.4
Client Version: Version 2.2.1-nightly20160523 (build 3390)

Build for OS X

@frank9999
Copy link

I'm building from source, latest commit in the 2.2 branch. I get the same results from your nightly build.

ClientOS: W10

@mcastroSG
Copy link

@frank9999 you are right, it´s not working properly, still testing to find a pattern

@mcastroSG
Copy link

Hi hi:

@ckamm I´ve made some test to discover something new, and i hope this could help to found a solution:

On a fresh Shared Sync folder:

Step Action X of Y shown Comments
1 Copy one file to Shared Sync root folder 1 of 1 OK
2 Copy two files to Shared Sync root folder 2 of 2 OK
3 Create a folder 1 of 1 OK
4 Copy one file to Shared Sync root folder 2 of 2 NOK
5 Copy one file to Shared Sync root folder 1 of 1 OK
6 Create a folder 1 of 1 OK
7 Copy two file to Shared Sync root folder 3 of 3 NOK
Step Action X of Y shown Comments
1 Create a folder1 1 of 1 OK
2 Copy one file to folder1 1 of 2 NOK
Step Action X of Y shown Comments
1 Copy one file to Shared Sync root folder 1 of 1 OK
2 Create a folder1 1 of 1 OK
3 Copy one file to folder1 1 of 3 NOK
Step Action X of Y shown Comments
1 Create a folder1 1 of 1 OK
2 Copy one file to folder1 1 of 2 NOK
3 Create a folder2 at folder1 1 of 1 OK
4 Copy one file to folder2 1 of 5 NOK
5 Copy one file to folder2 1 of 3 NOK
6 Copy one file to folder2 1 of 5 NOK
7 Copy one file to folder2 1 of 3 NOK
Step Action X of Y shown Comments
1 Create a folder1 1 of 1 OK
2 Create a folder2 at folder1 1 of 1 OK
3 Copy one file to folder2 1 of 3 NOK
4 Copy one file to folder2 1 of 3 NOK
Step Action X of Y shown Comments
1 Create a folder1 1 of 1 OK
2 Copy one file to folder1 1 of 2 NOK
3 Create a folder2 at folder1 1 of 1 OK
4 Copy one file to folder2 1 of 5 NOK
5 Create a folder3 at folder2 1 of 1 OK
6 Copy one file to folder3 1 of 7 NOK
7 Create a folder4 at folder3 1 of 1 OK
8 Copy one file to folder4 1 of 9 NOK
9 Copy one file to folder4 1 of 3 NOK
10 Copy one file to folder4 1 of 9 NOK

Results may vary due to I´ve checked that sometimes it returns 1 of 3 instead of 1 of 2 once you have created the first folder, but the pattern still remains.

@mcastroSG mcastroSG removed the ReadyToTest QA, please validate the fix/enhancement label May 23, 2016
@frank9999
Copy link

Is there any progress on this issue? We are willing to test any new patches as soon as you have them

@danimo
Copy link
Contributor

danimo commented May 25, 2016

@frank9999 Also here, you can help testing nightlies: https://download.owncloud.com/download/nightly/

@frank9999
Copy link

@danimo I just tested the following nightly: https://download.owncloud.com/desktop/daily/ownCloud-2.2.1.6112-nightly20160525-setup.exe.

Bug is still there.

@ckamm
Copy link
Contributor

ckamm commented May 25, 2016

I'll be able to look at this on Friday if it's still unresolved by then.

ckamm added a commit to ckamm/owncloud-client that referenced this issue May 27, 2016
@ckamm
Progress: Don't count dirs without propagation jobs owncloud#4856
a2175d2 
These directory SyncFileItems are necessary for bookkeeping
but should not influence the progress display at all.
@ckamm
Copy link
Contributor

ckamm commented May 27, 2016

@mcastroSG Thanks for all that data. I've found the origin of the surprising counts. Pull request: #4910

ckamm added a commit to ckamm/owncloud-client that referenced this issue May 27, 2016
@ckamm
Progress: Skip ignored files owncloud#4856
8a0a394
@ckamm ckamm mentioned this issue May 27, 2016
Merged
ckamm added a commit that referenced this issue May 27, 2016
@ckamm
Progress: Don't count items without propagation jobs #4856 (#4910)
b9fdae6 
* Progress: Don't count dirs without propagation jobs #4856

These directory SyncFileItems are necessary for bookkeeping
but should not influence the progress display at all.

* Progress: Skip ignored files #4856
@ckamm ckamm added the ReadyToTest QA, please validate the fix/enhancement label May 27, 2016
@ckamm
Copy link
Contributor

ckamm commented May 27, 2016

The patches have been merged and the next build should have correct file counts.

@frank9999
Copy link

The fix seems to work for me! Thanks!

@danimo danimo closed this as completed May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckamm ckamm

Labels
blue-ticket ReadyToTest QA, please validate the fix/enhancement
Projects
None yet
Milestone
2.2.1
Development

No branches or pull requests
9 participants
@michaelstingl @ckamm @ogoffart @guruz @dragotin @danimo @frank9999 @enoch85 @mcastroSG