Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sharing Dialog] Include "Show file listing" checkbox on public link section on folders #5837

Closed
2 tasks done
SamuAlfageme opened this issue Jun 14, 2017 · 3 comments
Closed
2 tasks done

Comments

@SamuAlfageme
Copy link
Contributor

SamuAlfageme commented Jun 14, 2017

See: owncloud/core#27548

API logic changes:

@ckamm
Copy link
Contributor

ckamm commented Jun 15, 2017

It looks like this should be gated by the "supports_upload_only" capability.

@ckamm
Copy link
Contributor

ckamm commented Jun 15, 2017

PR #5843, still need to trim the sharing menu when directory listings are unavailable

ckamm added a commit that referenced this issue Jun 16, 2017
It would have been much nicer to keep the menu assigned to the
QToolButton, but if one switches away from InstantPopup (to adjust the
entries before they're displayed), the button always gets a menu
indicator that can't be removed.
@ckamm
Copy link
Contributor

ckamm commented Jun 16, 2017

Further tracked in PR

@ckamm ckamm closed this as completed Jun 16, 2017
ckamm added a commit that referenced this issue Jul 7, 2017
It would have been much nicer to keep the menu assigned to the
QToolButton, but if one switches away from InstantPopup (to adjust the
entries before they're displayed), the button always gets a menu
indicator that can't be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants