Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link shares: Add "show file listing" option #5837 #5843

Merged
merged 2 commits into from Jul 7, 2017
Merged

Conversation

ckamm
Copy link
Contributor

@ckamm ckamm commented Jun 15, 2017

No description provided.

It would have been much nicer to keep the menu assigned to the
QToolButton, but if one switches away from InstantPopup (to adjust the
entries before they're displayed), the button always gets a menu
indicator that can't be removed.
Copy link
Contributor

@SamuAlfageme SamuAlfageme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

For reference, this is how the dialog looks with the new option enabled:

Will do some tests over old/non-capabilities servers but this looks ready to be merged.

@ckamm
Copy link
Contributor Author

ckamm commented Jun 20, 2017

@SamuAlfageme Hm, the spacing between these options doesn't look uniform on OSX. It makes a bit of sense though, since the two options are related, but wasn't intentional.

@ckamm ckamm merged commit 99b1f69 into master Jul 7, 2017
@ckamm ckamm deleted the filelisting branch July 7, 2017 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants