Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing VFS dialog behaves like confirmation #7710

Closed
HanaGemela opened this issue Jan 31, 2020 · 8 comments
Closed

Closing VFS dialog behaves like confirmation #7710

HanaGemela opened this issue Jan 31, 2020 · 8 comments
Assignees
@TheOneRing
Labels
bug feature:vfs native virtual files and placeholder implementation p3-medium Normal priority

Comments

@HanaGemela
Copy link
Contributor

macOS 10.15.2
Windows 10
client 2.6.1

Steps to recreate:

  1. Click on Enable (or disable) VFS -> Confirmation dialog will pop up
  2. Click the cross icon to close the dialog

Actual result: VFS has been enabled (respectively disabled).
Expected result: No changes to the files when the dialog has been closed
@HanaGemela HanaGemela added bug p3-medium Normal priority feature:vfs native virtual files and placeholder implementation labels Jan 31, 2020
TheOneRing added a commit to TheOneRing/client that referenced this issue Feb 3, 2020
@TheOneRing
[Wizard] Don't display the vfs dialog twice
6cf8544 
Fixes: owncloud#7710
@TheOneRing TheOneRing mentioned this issue Feb 3, 2020
Merged
TheOneRing added a commit to TheOneRing/client that referenced this issue Feb 3, 2020
@TheOneRing
[Wizard] Don't display the vfs dialog twice
3931957 
Fixes: owncloud#7710
TheOneRing added a commit to TheOneRing/client that referenced this issue Feb 3, 2020
@TheOneRing
[Wizard] Don't display the vfs dialog twice
bb73591 
Fixes: owncloud#7710
TheOneRing added a commit to TheOneRing/client that referenced this issue Feb 3, 2020
@TheOneRing
[Wizard] Don't display the vfs dialog twice
b9d7248 
Fixes: owncloud#7710
Fixes: owncloud#7712
TheOneRing added a commit to TheOneRing/client that referenced this issue Feb 11, 2020
@TheOneRing
[Wizard] Don't display the vfs dialog twice
588ed83 
Fixes: owncloud#7710
Fixes: owncloud#7712
@michaelstingl
Copy link
Contributor

fixed

@TheOneRing TheOneRing mentioned this issue Apr 7, 2020
Closed
47 tasks
@HanaGemela HanaGemela mentioned this issue Apr 29, 2020
Closed
@HanaGemela
Copy link
Contributor Author

Broken in 2.6.3263_rc1 (build 13516) macOS 10.15.3

Steps to recreate:

  1. Click on Disable VFS -> Confirmation dialog will pop up
  2. Click the cross icon to close the dialog

@HanaGemela HanaGemela reopened this Apr 30, 2020
TheOneRing added a commit to TheOneRing/client that referenced this issue May 4, 2020
@TheOneRing
VFS Dialog: Don't enable on close button clicked
76366d0 
Issue: owncloud#7710
@TheOneRing TheOneRing mentioned this issue May 4, 2020
Merged
TheOneRing added a commit that referenced this issue May 5, 2020
@TheOneRing
VFS Dialog: Don't enable on close button clicked
ec67589 
Issue: #7710
@HanaGemela
Copy link
Contributor Author

Still broken in 2.6.3263rc2 (build 13648)

@TheOneRing
Copy link
Member

vfs

@HanaGemela
Copy link
Contributor Author

Oh, we have more VFS dialogs :) I'm opening the dialog from the Account tab

@TheOneRing
Copy link
Member

That should behave the same 😭 I'll see

@TheOneRing
Copy link
Member

You where talking about the disable vfs dialog?

@HanaGemela
Copy link
Contributor Author

Yes. Enable is correct

@TheOneRing TheOneRing mentioned this issue May 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheOneRing TheOneRing

Labels
bug feature:vfs native virtual files and placeholder implementation p3-medium Normal priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TheOneRing @michaelstingl @HanaGemela