Wrong usage of QMessageBox::finished

[TheOneRing]

QMessageBox::finished also reports that the prompt was accepted when the user closed the dialog using the ❌ button ....
See: #7710

[TheOneRing]

src/gui/accountsettings.cpp:    connect(msgBox, &QMessageBox::finished, msgBox, [this, msgBox, folder](int result) {
src/gui/generalsettings.cpp:    connect(msgBox, &QMessageBox::finished, msgBox, [this, channel, msgBox](int result) {
src/gui/sharelinkwidget.cpp:    connect(messageBox, &QMessageBox::finished, this,

[TheOneRing]

ShareLinkWidget::confirmAndDeleteShare does it right

connect(messageBox, &QMessageBox::finished, this,
        [messageBox, yesButton, share]() {
        if (messageBox->clickedButton() == yesButton)
            share->deleteShare();
    });

[TheOneRing]

Testing:

• Enable experimental feature? in settings
• Disable virtual file support? in account setting
• Enable technical preview feature in wizard