Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] macOS: settings window does not open when starting again #8377

Closed
jnweiger opened this issue Jan 19, 2021 · 10 comments
Closed

[QA] macOS: settings window does not open when starting again #8377

jnweiger opened this issue Jan 19, 2021 · 10 comments
Labels
macOS p3-medium Normal priority
Milestone

Comments

@jnweiger
Copy link
Contributor

Seen with 2.7.5RC2

Start the client. If the settings window is open, hide it.
Find a desktop icon of the owncloud client.
Click the icon. the settings window should open.

On Windows and Linux it is possible to open the settings window, when clicking on the desktop icon.
On macOS the icons are unresponsive. Nothing happens with: Click, double click, or right click -> open.

I find two "desktop icons": one in the dock at the bottom of the screen, anotherone in the Applications folder.
image

Epected behaviour: The first click starts the client. (Tray icon appears at the top). The second click opens the settings window.

@jnweiger jnweiger mentioned this issue Jan 19, 2021
42 tasks
@TheOneRing
Copy link
Member

@felix-schwarz can we register a second invocation?
We use qsingle application and use ipc to communicate with the original instance.
As mac prevents multiple instances this of course does not work...

@TheOneRing
Copy link
Member

@jnweiger unrelated to this release

@felix-schwarz
Copy link

@TheOneRing If you try to relaunch a running app or click it in the dock, the app should receive a kAEReopenApplication AppleEvent. You should be able to get notified by implementing this AppDelegate method:

https://developer.apple.com/documentation/appkit/nsapplicationdelegate/1428638-applicationshouldhandlereopen?language=objc#

@TheOneRing
Copy link
Member

Thx

@TheOneRing TheOneRing added this to the 2.8.0 milestone Jan 19, 2021
@github-actions
Copy link

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 19, 2021
@TheOneRing TheOneRing added the p3-medium Normal priority label Feb 19, 2021
@github-actions github-actions bot removed the Stale label Feb 20, 2021
@gabi18
Copy link
Contributor

gabi18 commented May 4, 2021

Confirmed with client version 2.8 rc1 on BigSur 11.3.1.
When closing the client with the 'Hide' button on any window (not only on 'Settings') it cannot be reopened by clicking the dock icon.
This works, if the dialog is closed using minimize Bildschirmfoto 2021-05-04 um 10 03 37, the dock icon shows a dot Bildschirmfoto 2021-05-04 um 10 08 07 then.

If the dock icon doesn't have the dot, the client window can only be opened by clicking on sys tray icon (and choosing 'Last Changes...' 'Details or 'Settings') at the top Bildschirmfoto 2021-05-04 um 10 12 42

@gabi18
Copy link
Contributor

gabi18 commented May 4, 2021

The behavior on client start is similar. Clicking on the dock icon (single/double click) starts the client but the client doesn't appear. Also here, one have to use the systray icon on top.

@TheOneRing
Copy link
Member

@erikjv Could you have a look :)

@erikjv
Copy link
Collaborator

erikjv commented Jul 6, 2021

This should be handled by Qt by sending a QEvent::ApplicationActivate. (Well, if nobody messed with the delegate, etc.)

@TheOneRing
Copy link
Member

I think I tried to use that event before, but it did not behave as expected....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macOS p3-medium Normal priority
Projects
None yet
Development

No branches or pull requests

5 participants