Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac: Application should handle reopen #8812

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

erikjv
Copy link
Collaborator

@erikjv erikjv commented Jul 13, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2021

CLA assistant check
All committers have signed the CLA.

@erikjv erikjv requested a review from TheOneRing July 13, 2021 18:45
@TheOneRing TheOneRing force-pushed the work/applicationShouldHandleReopen branch from 23dc7e1 to f38c6c6 Compare July 22, 2021 10:19
@erikjv erikjv force-pushed the work/applicationShouldHandleReopen branch from f38c6c6 to 8d46c9f Compare July 28, 2021 13:37
@erikjv erikjv changed the title WIP: Work/application should handle reopen Mac: Application should handle reopen Jul 28, 2021
@erikjv erikjv force-pushed the work/applicationShouldHandleReopen branch 3 times, most recently from a3f35f5 to b834acf Compare July 29, 2021 09:34
@TheOneRing
Copy link
Member

Could you also add changelog entry like that one :)
https://github.com/owncloud/client/blob/master/changelog/unreleased/4542

@erikjv erikjv force-pushed the work/applicationShouldHandleReopen branch from b834acf to 9630240 Compare July 29, 2021 15:01
seemingly do nothing at all. To make this more consistent with other
macOS applications, relaunching will now open the settings dialog.

https://github.com/owncloud/client/pull/8812
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
https://github.com/owncloud/client/pull/8812
https://github.com/owncloud/client/issues/8377
https://github.com/owncloud/client/pull/8812

@erikjv erikjv force-pushed the work/applicationShouldHandleReopen branch from 9630240 to a159421 Compare July 30, 2021 09:21
@erikjv erikjv force-pushed the work/applicationShouldHandleReopen branch from a159421 to 9202a79 Compare July 30, 2021 09:24
@erikjv erikjv merged commit 8451274 into master Jul 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the work/applicationShouldHandleReopen branch July 30, 2021 09:26
@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2021

Please retry analysis of this Pull-Request directly on SonarCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants