Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the client icon in the file browser context menu #8464

Closed
TheOneRing opened this issue Mar 2, 2021 · 2 comments
Closed

Provide the client icon in the file browser context menu #8464

TheOneRing opened this issue Mar 2, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@TheOneRing
Copy link
Member

TheOneRing commented Mar 2, 2021

This feature was initially discussed in #6919 but as we provide branded clients just providing icon name is not possible for us.

The initial implementation should be used in https://github.com/owncloud/client/tree/master/shell_integration/dolphin

@TheOneRing TheOneRing added this to the 2.8.0 milestone Mar 2, 2021
@TheOneRing TheOneRing added this to Qualification in Releases via automation Mar 3, 2021
@TheOneRing TheOneRing moved this from Qualification to Desktop Testing in Releases Mar 3, 2021
@fmoc fmoc added the Linux label May 14, 2021
gabi18 pushed a commit that referenced this issue May 26, 2021
gabi18 added a commit that referenced this issue May 26, 2021
…ick menu (#8638)

* support V2/GET_CLIENT_ICON in socketapi, add icon to dolphin right click menu

* apply review improvements

* further improvements

* logging added, improvements

* improve OwncloudDolphinPluginHelper::slotReadyRead

* use line.mid(), add const

* changlog for #8464
@TheOneRing
Copy link
Member Author

Fixed in #8638

@jnweiger
Copy link
Contributor

Confirmed fixed in testpilotcloud 2.9.0-beta3

  • Provide a json based socket api call

  • -> V2/GET_CLIENT_ICON:{"size": 256, "theme": "dark"}

  • <- V2/CLIENT_ICON:{"size": 256, "theme":dark", "png": "blob" }

The exact syntax is:

  • -> V2/GET_CLIENT_ICON:{ "id": "1", "arguments": { "size": 256 } }
  • <- V2/GET_CLIENT_ICON_RESULT:{"arguments":{"png":"iVBORw0KGgoAAAA.... " }, "id": 1 }

@michaelstingl michaelstingl removed this from Desktop Testing in Releases Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants