Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileSystem::isFileLocked is incomplete and does not detect locking in all cases #8761

Closed
TheOneRing opened this issue Jun 21, 2021 · 2 comments
Closed

FileSystem::isFileLocked is incomplete and does not detect locking in all cases #8761

TheOneRing opened this issue Jun 21, 2021 · 2 comments

Comments

@TheOneRing
Copy link
Member

While the above function returns false CfOpenFileWithOplock fails due to locking.
WindowsError: ffffffff80070020: The process cannot access the file because it is being used by another process."
@TheOneRing
Copy link
Member Author

The current implementation tries to gain shared access and returns true if it succeeds, for vfs windows we might need exclusive access however.

TheOneRing added a commit that referenced this issue Jun 21, 2021
@TheOneRing
Require exclusive locks for vfs and renames
1bceb47 
Fixes: #8761
@TheOneRing TheOneRing mentioned this issue Jun 21, 2021
Merged
TheOneRing added a commit that referenced this issue Jun 21, 2021
@TheOneRing
Require exclusive locks for vfs and renames
660c05d 
Fixes: #8761
TheOneRing added a commit that referenced this issue Jun 21, 2021
@TheOneRing
Require exclusive locks for vfs and renames
ccb4c4b 
Fixes: #8761
TheOneRing added a commit that referenced this issue Jun 21, 2021
@TheOneRing
Require exclusive locks for vfs and renames
1a3787f 
Fixes: #8761
@TheOneRing
Copy link
Member Author

#8754

TheOneRing added a commit that referenced this issue Jun 21, 2021
@TheOneRing
Require exclusive locks for vfs and renames
d79b4a1 
Fixes: #8761
TheOneRing added a commit that referenced this issue Jun 21, 2021
@TheOneRing
Require exclusive locks for vfs and renames
4f5ccbb 
Fixes: #8761
@jnweiger jnweiger mentioned this issue Aug 23, 2021
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheOneRing