Require exclusive locks for vfs and renames #8763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
force-pushed
the
work/lock_exclusive
branch
from
1bceb47
to
660c05d
Compare
TheOneRing
force-pushed
the
work/lock_exclusive
branch
from
660c05d
to
ccb4c4b
Compare
TheOneRing
force-pushed
the
work/lock_exclusive
branch
from
ccb4c4b
to
1a3787f
Compare
dragotin
reviewed
Jun 21, 2021
| if (!FileSystem::isFileLocked(it.key(), it.value())) { | ||
| qCInfo(lcLockWatcher) << "Lock of" << it.key() << "was released"; | ||
| emit fileUnlocked(it.key()); | ||
| unlocked.insert(it.key()); | ||
| } | ||
| } | ||
|
|
||
| // Doing it this way instead of with a QMutableSetIterator | ||
| // ensures that calling back into addFile from connected | ||
| // slots isn't a problem. |
There was a problem hiding this comment.
Not sure if this comment is sufficient still?
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8761, #8754