Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop client not showing overlay icons if name has a space at the end #9030

Closed
belth245 opened this issue Sep 15, 2021 · 2 comments
Closed

Desktop client not showing overlay icons if name has a space at the end #9030

belth245 opened this issue Sep 15, 2021 · 2 comments
Assignees
@erikjv
Labels
Discussion macOS p2-high Escalation, on top of current planning, release blocker
Milestone
2.10.1

Comments

@belth245
Copy link

Expected behaviour

  • Finder should show the expected status icon
  • Finder context menu shows usual options including VFS options

Actual behaviour

  • Finder shows no icon at all
  • Finder context menu is not showing the usual options

Bildschirmfoto 2021-09-15 um 14 42 09

Bildschirmfoto 2021-09-15 um 14 42 55

Steps to reproduce

  1. Create folder with a space at the end of the name
  2. Navigate into the folder and back out again
  3. Icon has vanished

Operating system:
MacOS 11.5.2

OwnCloud Client 2.9.0 (build 5150)
OwnCloud Server: 10.7.0.4 Enterprise

OS language: German / English

Most actions seem to appropriate values but for some actions the client seems to trim spaces off (i.e. folder sync status and context menu):

Log_01_FolderStatus

Log_02_MenuItems
@TheOneRing
Copy link
Member

You hit a limitation of our old socket api (We have plans to modernise it).
Be aware that files with spaces at the and also can't be synced to Windows.

@fmoc fmoc added the macOS label Sep 17, 2021
@github-actions
Copy link

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 18, 2021
@michaelstingl michaelstingl added this to the Backlog milestone Oct 18, 2021
@TheOneRing TheOneRing removed the Stale label Oct 18, 2021
@TheOneRing TheOneRing modified the milestones: Backlog, 2.10 Feb 14, 2022
@TheOneRing TheOneRing modified the milestones: 2.10, 2.10.1 Feb 14, 2022
@TheOneRing TheOneRing added the p2-high Escalation, on top of current planning, release blocker label Feb 14, 2022
@erikjv erikjv self-assigned this Feb 16, 2022
erikjv added a commit that referenced this issue Feb 16, 2022
@erikjv
SocketAPI: Do not strip trailing whitespace from paths
1306a94 
When stripped, the wrong file name is queried in the DB, and the status
badges shown in Finder will not be there.

#9030
@erikjv erikjv mentioned this issue Feb 16, 2022
Merged
erikjv added a commit that referenced this issue Feb 16, 2022
@erikjv
SocketAPI: Do not strip trailing whitespace from paths
00b4468 
When stripped, the wrong file name is queried in the DB, and the status
badges shown in Finder will not be there.

#9030
#9452
erikjv added a commit that referenced this issue Feb 17, 2022
@erikjv
SocketAPI: Do not strip trailing whitespace from paths
0fa2acb 
When stripped, the wrong file name is queried in the DB, and the status
badges shown in Finder will not be there.

#9030
#9452
erikjv added a commit that referenced this issue Feb 17, 2022
@erikjv
SocketAPI: Do not strip trailing whitespace from paths
06253e1 
When stripped, the wrong file name is queried in the DB, and the status
badges shown in Finder will not be there.

#9030
erikjv added a commit that referenced this issue Feb 17, 2022
@erikjv
SocketAPI: Do not strip trailing whitespace from paths
55598bb 
When stripped, the wrong file name is queried in the DB, and the status
badges shown in Finder will not be there.

#9030
erikjv added a commit that referenced this issue Feb 17, 2022
@erikjv
SocketAPI: Do not strip trailing whitespace from paths
01a0eb0 
When stripped, the wrong file name is queried in the DB, and the status
badges shown in Finder will not be there.

Fixes: #9030
@TheOneRing TheOneRing mentioned this issue Mar 10, 2022
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikjv erikjv

Labels
Discussion macOS p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Milestone
2.10.1
Development

No branches or pull requests
5 participants
@erikjv @TheOneRing @michaelstingl @belth245 @fmoc