SocketAPI: Do not strip trailing whitespace from paths #9452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjv
force-pushed
the
work/undo-strip-whitespace-in-SocketAPI
branch
from
1306a94
to
00b4468
Compare
|
Ouch, that was me, thx for fixing. |
erikjv
force-pushed
the
work/undo-strip-whitespace-in-SocketAPI
branch
from
00b4468
to
0fa2acb
Compare
|
Changlog is wrong, needs to be |
|
And could you uses the |
erikjv
force-pushed
the
work/undo-strip-whitespace-in-SocketAPI
branch
2 times, most recently
from
06253e1
to
55598bb
Compare
When stripped, the wrong file name is queried in the DB, and the status badges shown in Finder will not be there. Fixes: #9030
erikjv
force-pushed
the
work/undo-strip-whitespace-in-SocketAPI
branch
from
55598bb
to
01a0eb0
Compare
|
Kudos, SonarCloud Quality Gate passed! |
TheOneRing
approved these changes
Feb 17, 2022
delete-merged-branch
bot
deleted the
work/undo-strip-whitespace-in-SocketAPI
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stripped, the wrong file name is queried in the DB, and the status
badges shown in Finder will not be there.
#9030