Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] Account Filter for Server Activity does not do anything #9425

Closed
jnweiger opened this issue Feb 8, 2022 · 3 comments
Closed

[QA] Account Filter for Server Activity does not do anything #9425

jnweiger opened this issue Feb 8, 2022 · 3 comments
Assignees
@erikjv
Labels
p2-high Escalation, on top of current planning, release blocker
Milestone
2.10.1

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Feb 8, 2022 •
edited
Loading

Seen on 2.10.0rc3 (build 6436) in Linux Mint

  • connect multiple servers.
  • wait for server activity messages to come
  • view Activity -> Server Activity
  • click Filter, three accounts are shown there. Choose one.
  • Still Activity messages from all accounts are shown. BAD

image

The screenhot shows the situation after re-opening the Filter dropdown. The Account column shows accounts not filtered for.

The available filters in the the other tabs (Activity -> Sync Protocol tab and in Activity -> Not Synced) work fine.
@jnweiger
Copy link
Contributor Author

jnweiger commented Feb 8, 2022 •
edited
Loading

@enbrnz @gabi18 fyi
Possibly a followup on #7005

@gabi18
Copy link
Contributor

gabi18 commented Feb 8, 2022

Also seen with ownCloud 2.10.0 (build 6519) on Windows 10 20H2

@jnweiger
Copy link
Contributor Author

jnweiger commented Feb 8, 2022 •
edited
Loading

UX improvement ideas:

  • Replace the default choice "No filter" with "All" (avoid brain-fog due to double negation)
  • When a filter is active, replace the label "Filter" on the drop down button with something that indicates that a filter is active. (avoid loss off context)

@TheOneRing TheOneRing added this to the 2.10.1 milestone Feb 8, 2022
@TheOneRing TheOneRing added the p2-high Escalation, on top of current planning, release blocker label Feb 14, 2022
@erikjv erikjv self-assigned this Feb 24, 2022
erikjv added a commit that referenced this issue Mar 2, 2022
@erikjv
Fix account filtering in Server Activity tab
9fa9382 
Fixes: #9425
@erikjv erikjv mentioned this issue Mar 2, 2022
Merged
erikjv added a commit that referenced this issue Mar 3, 2022
@erikjv
Fix account filtering in Server Activity tab
9293f81 
The `Models::addFilterMenuItems` method is used in 2 cases, once in the
`ActivityWidget`, and once in the `ProtocolWidget`. Both have their own
item model, so both need their own role passed in for filtering on.

The bug was that `ProtocolItemModel::ProtocolItemRole::Account` was used
forall cases, even when a `ActivityListModel::ActivityRole::Account`
should have been passed in.

Fixes: #9425
erikjv added a commit that referenced this issue Mar 11, 2022
@erikjv
Fix account filtering in Server Activity tab
a6bc1d5 
The `Models::addFilterMenuItems` method is used in 2 cases, once in the
`ActivityWidget`, and once in the `ProtocolWidget`. Both have their own
item model, so both need their own role passed in for filtering on.

The bug was that `ProtocolItemModel::ProtocolItemRole::Account` was used
forall cases, even when a `ActivityListModel::ActivityRole::Account`
should have been passed in.

Fixes: #9425
TheOneRing pushed a commit that referenced this issue Mar 11, 2022
@erikjv @TheOneRing
Fix account filtering in Server Activity tab
2fc0c11 
The `Models::addFilterMenuItems` method is used in 2 cases, once in the
`ActivityWidget`, and once in the `ProtocolWidget`. Both have their own
item model, so both need their own role passed in for filtering on.

The bug was that `ProtocolItemModel::ProtocolItemRole::Account` was used
forall cases, even when a `ActivityListModel::ActivityRole::Account`
should have been passed in.

Fixes: #9425
@gabi18 gabi18 mentioned this issue Mar 15, 2022
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikjv erikjv

Labels
p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Milestone
2.10.1
Development

No branches or pull requests
4 participants
@erikjv @TheOneRing @jnweiger @gabi18