Fix account filtering in Server Activity tab #9481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjv
force-pushed
the
work/fix-account-filter-logic
branch
from
9fa9382
to
9293f81
Compare
TheOneRing
reviewed
Mar 4, 2022
fmoc
suggested changes
Mar 9, 2022
The `Models::addFilterMenuItems` method is used in 2 cases, once in the `ActivityWidget`, and once in the `ProtocolWidget`. Both have their own item model, so both need their own role passed in for filtering on. The bug was that `ProtocolItemModel::ProtocolItemRole::Account` was used forall cases, even when a `ActivityListModel::ActivityRole::Account` should have been passed in. Fixes: #9425
erikjv
force-pushed
the
work/fix-account-filter-logic
branch
from
9293f81
to
a6bc1d5
Compare
TheOneRing
approved these changes
Mar 11, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9425