-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log HTTP requests and responses #7891
Conversation
9284b1c
to
e0fb2f1
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool!!
Is there any indicator (thread id…?) which response belongs to a request?
Perfect solution would be, to add the X-Request-ID
from a request, also to the line with the corresponding response.
Indeed cool. In addition to what @michaelstingl said, maybe we need to log the grep-able account ID or folder too (or a special value if there is no account associated) |
|
How about -> and <- instead of response request? |
06acce1
to
1a08059
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove the global namespace specifiers to logHttp, apart from that ok
Logging is disabled by default, it can be enabled by using:
QT_LOGGING_RULES = "sync.httplogger=true"
See #7873