Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui: Rename "General" -> "Settings" and move "Network" -> "Settings" #7962

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

TheOneRing
Copy link
Member

@TheOneRing TheOneRing commented Jul 15, 2020

image

@TheOneRing TheOneRing requested a review from dschmidt July 15, 2020 12:19
@TheOneRing TheOneRing changed the title Gui: Rename General Settings and unite with network settings Gui: Rename "General" -> "Settings" and move "Network" -> "Settings" Jul 15, 2020
@jnweiger
Copy link
Contributor

That is a good improvement! I like it! 👍

Next improvement idea for that topic: Allow different settings per account?

@dschmidt
Copy link
Member

The scroll area is just to make this fit on a small screen, right?

Is it neccessary to scroll on a big enough screen?

@dschmidt
Copy link
Member

dschmidt commented Jul 20, 2020

Screenshot_20200720_133552

This is the minimal size to hide the scrollbars.

To be honest, I think this is too big and that the version info at the bottom being fixed makes it overall a bit awkward to use when scrollbars are shown.

@TheOneRing
Copy link
Member Author

Right now the window is not full screen but 800x500 so the scroll area is needed.
The version stuff is important and should always be visible.
With the scroll area the network stuff is partly hidden but I'd expect that most user will never interact with them at all.

Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise this is ok

Personally I rather dislike the change visually ... because I think it's too big and awkward to use

@TheOneRing
Copy link
Member Author

Les see how it feels, we can always change it.

@TheOneRing TheOneRing merged commit c04ac8f into owncloud:master Jul 20, 2020
@TheOneRing TheOneRing deleted the settings branch July 20, 2020 11:51
@jnweiger jnweiger mentioned this pull request Oct 13, 2020
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants