Add branding option to enforce VFS on Windows #8179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TheOneRing
commented
Oct 20, 2020
•
TheOneRing
commented
|
Kudos, SonarCloud Quality Gate passed!
|
|
On a general note: If we have an option "forceVFS" that makes the "enableExperimentalFeature" option obsolete automatically. How would we have a way to force an experimental feature? That does not make sense IMHO. |
|
The branch is horrible outdated, by now windows vfs is no longer an experimental feature... |
TheOneRing
force-pushed
the
work/enforce_vfs
branch
from
80198b0
to
9185811
Compare
TheOneRing
changed the title
TheOneRing
force-pushed
the
work/enforce_vfs
branch
3 times, most recently
from
0b2b2f1
to
71ed74d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
dschmidt
approved these changes
Apr 15, 2021
src/gui/folderwizard.cpp
Outdated
| if (Theme::instance()->showVirtualFilesOption() && vfsMode != Vfs::Off && (vfsMode == Vfs::WindowsCfApi || Theme::instance()->enableExperimentalFeatures())) { | ||
|
|
||
| if (Theme::instance()->forceVirtualFilesOption() && vfsMode == Vfs::WindowsCfApi) { | ||
| // using an else if too make the condition not even more complex... |
TheOneRing
force-pushed
the
work/enforce_vfs
branch
from
71ed74d
to
8df31d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.