Fix filename clash detection with virtual files #8339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
force-pushed
the
work/cleanup_localFileNameClash
branch
from
2055e3b
to
825f80c
Compare
TheOneRing
force-pushed
the
work/cleanup_localFileNameClash
branch
2 times, most recently
from
53143cd
to
55b44be
Compare
TheOneRing
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
dragotin
approved these changes
Jan 18, 2021
| qCWarning(lcPropagator) << "No valid fileinfo"; | ||
| return false; |
There was a problem hiding this comment.
I do not like this style. Tbh.
|
TODO @TheOneRing rebase on release branch... |
TheOneRing
force-pushed
the
work/cleanup_localFileNameClash
branch
from
55b44be
to
7110c09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: Detect file name clash with VirtualFiles enabled
We fixed an issue where the file name clash detection was not run with
VirtualFiles enabled.
#8323