Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make findBestChecksum case insensitive #8371

Merged
merged 2 commits into from
Jan 18, 2021
Merged

Make findBestChecksum case insensitive #8371

merged 2 commits into from
Jan 18, 2021

Conversation

TheOneRing
Copy link
Member

No description provided.

dragotin
dragotin approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@dragotin dragotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that 🙈

src/common/checksums.cpp
{
const auto checksums = QString::fromUtf8(_checksums);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this auto confusing, because I have to think about to where fromUtf8 converts.

src/common/checksums.cpp Show resolved Hide resolved
@TheOneRing TheOneRing merged commit efe18f3 into 2.7 Jan 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the work/fix_checksum_header branch January 18, 2021 21:47
@TheOneRing TheOneRing mentioned this pull request Apr 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragotin dragotin dragotin approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheOneRing @dragotin