Instead of renaming the targets, we rename their output #8482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
force-pushed
the
wokr/fix_space_target
branch
from
a16fdc9
to
d6206c4
Compare
dschmidt
approved these changes
Mar 11, 2021
This fixes brandings with spaces in the name
TheOneRing
force-pushed
the
wokr/fix_space_target
branch
from
d6206c4
to
981d398
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
@TheOneRing do you have an example branding with a whitespace? |
|
"own Cloud" its for the .exe name and the dll names |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes brandings with spaces in the name
Do we need a changelog entry for that?