Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Retry action to the protocol items #8584

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Add Retry action to the protocol items #8584

merged 1 commit into from
Apr 29, 2021

Conversation

TheOneRing
Copy link
Member

No description provided.

@TheOneRing
Copy link
Member Author

image

@michaelstingl
Copy link
Contributor

Nice one 👍

Does it work with blacklisted items? Does it maybe reset the blacklist status?

@TheOneRing
Copy link
Member Author

That's exactly what it does :)
It removes them from the ignore list and starts a new sync.
For now it only available if a single file is selected, we might allow to select multiple.
The old code added a button on items which where due to quota issues, now it should be available on all errors.

@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

michaelstingl
michaelstingl approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@michaelstingl michaelstingl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheOneRing TheOneRing mentioned this pull request Apr 28, 2021
Merged
@TheOneRing TheOneRing merged commit 2059414 into master Apr 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the work/rety_action branch April 29, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstingl michaelstingl michaelstingl approved these changes

@fmoc fmoc fmoc approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TheOneRing @michaelstingl @fmoc