Fix a mac the socket api crash #8664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
force-pushed
the
work/fix_concurrency_issue
branch
from
f2540a2
to
64227d0
Compare
|
@michaelstingl this calls for a 2.8.2 and delays ownbrander deployment. Do you agree? |
yes, understood 👍 |
|
The crash reports we get are all on mac, so its probably related to the special rpc implementation on mac.... |
fmoc
suggested changes
May 28, 2021
TheOneRing
force-pushed
the
work/fix_concurrency_issue
branch
3 times, most recently
from
d848a4a
to
2cc549b
Compare
TheOneRing
changed the title
fmoc
approved these changes
May 28, 2021
On mac SocketApiSocket::writeData can emit disconnected() This caused a modification of the map containing the sockets during the iteration and thus a crash.
TheOneRing
force-pushed
the
work/fix_concurrency_issue
branch
from
2cc549b
to
f0c0dfd
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.