Branding option to disable the multiple db files warning #9216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
force-pushed
the
work/del_multi_db
branch
from
2dc1331
to
2806b57
Compare
dragotin
reviewed
Nov 15, 2021
| .arg(path); | ||
| qCWarning(lcFolderMan) << error; | ||
| if (Theme::instance()->warnOnMultipleDb()) { | ||
| return error; |
There was a problem hiding this comment.
Not sure I like this: In the logfile, you will find the Warning/Error, but in fact the code does not return the error. That will be very confusing in debugging situations. Rather add a hint that it was disabled for the log as well.
There was a problem hiding this comment.
I modified the log message, not sure this is really better 🤷♀️
dschmidt
reviewed
Nov 16, 2021
TheOneRing
force-pushed
the
work/del_multi_db
branch
from
2377b79
to
1f7fb66
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cache error message to prevent unnecessary listing of sync root.