Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix photo upload #477

Merged
merged 2 commits into from
Aug 23, 2016
Merged

Fix photo upload #477

merged 2 commits into from
Aug 23, 2016

Conversation

DeepDiver1975
Copy link
Member

fixes #425

@mention-bot
Copy link

@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jancborchardt, @Henni and @skjnldsv to be potential reviewers

@DeepDiver1975 DeepDiver1975 added this to the 1.4 milestone Aug 2, 2016
@codecov-io
Copy link

Current coverage is 12.08% (diff: 0.00%)

Merging #477 into master will decrease coverage by 0.04%

@@             master       #477   diff @@
==========================================
  Files            45         45          
  Lines           816        819     +3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits             99         99          
- Misses          717        720     +3   
  Partials          0          0          

Sunburst

Powered by Codecov. Last update b8c3e06...a39931b

@jancborchardt
Copy link
Member

@ManOki @Rello can you review this since it fixes your reported issue? :)

@MariusBluem
Copy link
Contributor

👍 ... Tested and works for me.

@MariusBluem
Copy link
Contributor

Could we have some more tests? @jancborchardt @Henni

@DeepDiver1975 DeepDiver1975 merged commit 09ab217 into master Aug 23, 2016
@DeepDiver1975 DeepDiver1975 deleted the fix-photo-upload branch August 23, 2016 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid VCard PHOTO TYPE
5 participants