Merge pull request #13236 from owncloud/use-isset-for-performance

Use isset() instead of strlen()
owncloud · Jan 10, 2015 · 8057bc6 · 8057bc6
2 parents 74d1a9e + 310424d
commit 8057bc6
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/private/files/view.php b/lib/private/files/view.php
@@ -1278,8 +1278,10 @@ public function getPath($id) {
 
 	private function assertPathLength($path) {
 		$maxLen = min(PHP_MAXPATHLEN, 4000);
-		$pathLen = strlen($path);
-		if ($pathLen > $maxLen) {
+		// Check for the string length - performed using isset() instead of strlen()
+		// because isset() is about 5x-40x faster.
+		if(isset($path[$maxLen])) {
+			$pathLen = strlen($path);
 			throw new \OCP\Files\InvalidPathException("Path length($pathLen) exceeds max path length($maxLen): $path");
 		}
 	}