Server to Server: 7.0.0 Trusted_Domain and Error Messages

[MTRichards]

When I log into ownCloud for the first time and set it up, and I do so from localhost, this is what is set in the config file for trusted_domains. Then, when I create a server-to-server share it generates a localhost URL, which obviously is no good for actual server-to-server sharing (See attachment).

If I edit the URL manually, replacing 'localhost' with the server's hostname 'studio', it generates an 'Error loading slideshow template' message. This message is not representative of the problem. The problem is that the trusted_domain config file entry needs to be edited to add the URL (in this case IP and / or host name) to resolve the problem.

The error message needs to be updated to be indicative of the problem, something like "untrusted host" or something, so the problem can be addressed by the admin.

[MTRichards]

@karlitschek @LukasReschke

[DeepDiver1975]

@MTRichards this is by design of the trusted domain setting: you have to add all domains the instance can/shall be accessed from in the config.php

[MTRichards]

The error message needs to be updated to be indicative of the problem, something like "untrusted host" or something, so the problem can be addressed by the admin.

The issue is not that it does or doesn't work, but that the error message that is thrown is useless. It is not the slideshow template at all, rather the error message should be "untrusted host domain" or something like this.

@LukasReschke

[karlitschek]

hmm. not sure it is correct that the sharing link generation is using the trusted domain setting. We should have a separate setting for the current url. This also affects the notification emails. @nickvergessen
Maybe we can use the overwrite* setting or something new?

[nickvergessen]

The existing overwrite* configs should already cover that.
They are (or should) be used for all generated links.

@MTRichards can you try the overwrite settings, see config.sample.php for help?

[MTRichards]

Just to clarify.... because I can fix the problem by updating the trusted domain to include the IP of my server.

We just need an update to the error message so it says what the error is, and an admin can figure it out and solve it. Current message says

"'Error loading slideshow template"

It should say something like "Untrusted host" or something like that.

[LukasReschke]

Mhm, I saw the message also in some other cases. I doubt this is related to that. I'll dive into this tomorrow.

[MTRichards]

Thanks @LukasReschke !

[PVince81]

The "error loading slideshow" usually appears when there's any JS error happening that somehow impairs the slideshow app.

[LukasReschke]

@PVince81 Yeah, in this case it was triggered by the reason that the gallery app was routed via index.php but the sharing via public.php

I fixed this error here with #10889 - feel free to review.