Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move trusted domain check to init() #10889

Merged
merged 1 commit into from
Sep 5, 2014
Merged

Conversation

LukasReschke
Copy link
Member

handleRequest() is not called from remote.php or public.php which made these files party available but all included apps in there produced errors.

As the expected behaviour is anyways that a trusted domain warning is shown I moved this to init()

Testplan:

  • Open a shared link from an untrusted domain without this patch => Works and gallery error is shown
  • Open a shared link from an untrusted domain with this patch => Trusted domain error is shown

Fixes #10064

@MTRichards Please review.
@karlitschek I think we want to backport this to stable7.

handleRequest() is not called from remote.php or public.php which made these files party available but all included apps in there produced errors.

As the expected behaviour is anyways that a trusted domain warning is shown I moved this to init()

Fixes #10064
@LukasReschke
Copy link
Member Author

@th3fallen An easy one for you ;-)

@scrutinizer-notifier
Copy link

A new inspection was created.

@LukasReschke LukasReschke added this to the 2014-sprint-03-current milestone Sep 5, 2014
@ghost
Copy link

ghost commented Sep 5, 2014

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/7114/

@LukasReschke
Copy link
Member Author

@owncloud-bot Retest this please.

@th3fallen
Copy link
Contributor

👍

@PVince81
Copy link
Contributor

PVince81 commented Sep 5, 2014

When you say "from an untrusted domain" you mean I should change the host name to use another domain that would have access but is not in the trusted list ?

@LukasReschke
Copy link
Member Author

When you say "from an untrusted domain" you mean I should change the host name to use another domain that would have access but is not in the trusted list ?

Exactly. I have added a new entry in my hosts file for that.

@PVince81
Copy link
Contributor

PVince81 commented Sep 5, 2014

👍 works

@ghost
Copy link

ghost commented Sep 5, 2014

💣 Test Failed. 💣
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/7116/

@LukasReschke
Copy link
Member Author

@owncloud-bot Retest this please.

@ghost
Copy link

ghost commented Sep 5, 2014

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/7120/

LukasReschke added a commit that referenced this pull request Sep 5, 2014
@LukasReschke LukasReschke merged commit f5951b2 into master Sep 5, 2014
@LukasReschke LukasReschke deleted the moveTrustedDomainCheck branch September 5, 2014 15:39
@LukasReschke
Copy link
Member Author

@karlitschek Backport? This fixes a bug reported by @MTRichards,

@karlitschek
Copy link
Contributor

Yes please. As discussed

@LukasReschke
Copy link
Member Author

Stable7: 640abbe

@lock lock bot locked as resolved and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server to Server: 7.0.0 Trusted_Domain and Error Messages
6 participants