-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move trusted domain check to init() #10889
Conversation
handleRequest() is not called from remote.php or public.php which made these files party available but all included apps in there produced errors. As the expected behaviour is anyways that a trusted domain warning is shown I moved this to init() Fixes #10064
@th3fallen An easy one for you ;-) |
A new inspection was created. |
💣 Test Failed. 💣 |
@owncloud-bot Retest this please. |
👍 |
When you say "from an untrusted domain" you mean I should change the host name to use another domain that would have access but is not in the trusted list ? |
Exactly. I have added a new entry in my hosts file for that. |
👍 works |
💣 Test Failed. 💣 |
@owncloud-bot Retest this please. |
🚀 Test Passed. 🚀 |
Move trusted domain check to init()
@karlitschek Backport? This fixes a bug reported by @MTRichards, |
Yes please. As discussed |
Stable7: 640abbe |
handleRequest() is not called from remote.php or public.php which made these files party available but all included apps in there produced errors.
As the expected behaviour is anyways that a trusted domain warning is shown I moved this to init()
Testplan:
Fixes #10064
@MTRichards Please review.
@karlitschek I think we want to backport this to stable7.