Automatic upgrade after package upgrade

[PVince81]

Since OC 7 there's a "Update now" button that needs to be clicked manually.

Ideally admins should rather run ./occ upgrade to make sure to not run into PHP timeouts.

The idea is to provide a mechanism to run an unattended upgrade:

1. In the case of distro packages, automatically run ./occ upgrade on the instance
2. In the case of tarballs, provide a config.php option to disable the "Update now" button and run the upgrade automatically (but need to look into potential concurrency issues if multiple people open OC at the same time)

CC @jnweiger

[PVince81]

Additionally it reminds me of #10602. In pre-install the package should first enable maintenance mode to prevent people accessing the OC instance while the files are overwritten.

So the idea is:

• preinstall: ./occ maintenance:mode --on
• postinstall: ./occ upgrade

This would also assume that the admin already have a backup mechanism in place.

[jnweiger]

I've added a draft to the specfile at https://build.opensuse.org/package/show/home:jnweiger:branches:isv:ownCloud:community:7.0/owncloud

Should that do the job? It also should obsolete messing around with apache, I suppose!

When we say 'occ upgrade', does that automatically end maintenance mode?

[PVince81]

@jnweiger last time when I upgraded to 7.0.3 on openSUSE, I did the following:

1. Manually set maintenance to true
2. zypper update
3. ./occ upgrade

After that it seemed that the maintenance mode was gone, so the answer to your question is: yes

[jnweiger]

@PVince81 thanks!

[MorrisJobke]

@PVince81 @jnweiger Keep in mind, that the user of the webserver could be something really special and not determinable. I guess an output like "You need to run upgrade manually" would be less harmful. Or am I wrong?

[jnweiger]

@MorrisJobke In my branch I am running occ as root during install. Should it be run as webserver user instead?

Detemining the name of the webserver user is not an issue. This is already part of the installation procedure.

[MorrisJobke]

@jnweiger Yes. Because it sometimes also modifies files (I remind some config.php fixes) that the webserver should be able to write afterwards. cc @LukasReschke Didn't you add this?

[LukasReschke]

Yup. Run occ ever only as webserver user. Everything else might lead to problems and should also not work (at least for some commands it doesn't)

[jnweiger]

@LukasReschke thanks! (Sounds like we want to have that as an assertion in occ ... )
I've added su to my branch. I still lack a test suite for update scenarios, though...

[jnweiger]

https://build.opensuse.org/package/show/home:jnweiger:branches:isv:ownCloud:community:7.0/owncloud got lost meanwhile. Restored.

[jnweiger]

Merged into https://build.opensuse.org/package/show/isv:ownCloud:community:8.0/owncloud

[jnweiger]

Implementation is in debian.owncloud-server.preinst debian.owncloud-server.postinst
Confirmed working well for owncloud 7->8 ugrade. Please reopen, if needed for 7.0.x updates.

[mcnesium]

Doesnt look like it works over here. OC 8 -> 8.0.1

[mcnesium]

has this been snafu-related?

[mcnesium]

It had, obviously. The current method is way better than it used to be for users (if it finally works*). Thank you for changing that!