Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text editor does not open in stable45 branch #126

Closed
blizzz opened this issue Oct 28, 2012 · 15 comments
Closed

Text editor does not open in stable45 branch #126

blizzz opened this issue Oct 28, 2012 · 15 comments
Assignees
Labels

Comments

@blizzz
Copy link
Contributor

blizzz commented Oct 28, 2012

Clicking on a text file should open the text editor, but it does not. Other viewers work. Happens with stable45 branch, master is ok.

@samtuke
Copy link
Contributor

samtuke commented Oct 28, 2012

Confirmed on Fedora 17 with FF 15 and Chromium.

@VicDeo
Copy link
Member

VicDeo commented Oct 28, 2012

please check if it is fixed with this commit:
d428d72

I'll merge it to stable45 if it does helps.

@blizzz
Copy link
Contributor Author

blizzz commented Oct 29, 2012

The problem lies not in master but in stable45.

I tried this commit in the stable45 branch, but it did not solve the issue unfortunately.

@tomneedham
Copy link
Member

Can anyone still confirm this? I am having no problem at all on either master or stable45 branch.

@blizzz
Copy link
Contributor Author

blizzz commented Nov 6, 2012

Tested with current stable45, works for me now (except, with empty files, iirc there is another report for this, no?)

@tomneedham
Copy link
Member

I fixed this in: owncloud-archive/apps@8f68017

Editing empty files works for me in master and stable45

@blizzz
Copy link
Contributor Author

blizzz commented Nov 6, 2012

Sorry, i meant empty files without extension. It does not work to open them in stable45 nor master (only after creation on master).

@tomneedham
Copy link
Member

Can you check what the mime type is please? For me, I can open empty files with or without extensions as long as the mime type is application/x-empty

@tomneedham
Copy link
Member

Have you pulled the apps repo branch stable45?

@blizzz
Copy link
Contributor Author

blizzz commented Nov 6, 2012

Mimetype is inode/x-empty, stable45 core+apps up to date.

@tomneedham
Copy link
Member

And this is a file created using New > Text file button? Odd how they have different mimetypes. Maybe different OS's? I can easily register that mimetype as well if that is the case.

@blizzz
Copy link
Contributor Author

blizzz commented Nov 6, 2012

Exactly. I'm running here Kubuntu, i.e. Ubuntu so most probably like Debian.
+1 for registering.

@ghost ghost assigned tomneedham Nov 6, 2012
@tomneedham
Copy link
Member

@blizzz can you confirm this fixes the issue: owncloud-archive/apps@254e8c1

@blizzz
Copy link
Contributor Author

blizzz commented Nov 7, 2012

This works! Can you backport it to stable45, please?

@tomneedham
Copy link
Member

Done: owncloud-archive/apps@7acd3fa

aditmeno pushed a commit to aditmeno/Aeolus that referenced this issue Apr 2, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Aug 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants