-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Add trusted domains" button doesn't work #14320
Comments
@LukasReschke can you have a look? |
@SergioBertolinSG |
There is an error while getting this file |
Hi, this message itself is a duplicate of #14057 Not quite sure if this is causing your problem. |
Message is unrelated. That's just some browser debugging feature. Let me look at this. |
Ok, that javascript was unrelated. There weren't more javascript errors. While clicking the button, an error message about web not available shows., showing this on networking. GET http://owncloud_18-02-15/index.php/settings/admin?trustDomain=10.40.40.130 net::ERR_NAME_NOT_RESOLVED |
Can you post your config? |
Well, it is a new installation, coming from #14321. But i saw this all the time before, this button has never worked. I always had to edit config.php to add the trusted domain manually. |
It actually should work fine if the instance is configured properly and both addresses are accessible. The question here is more how we come into this inconsistent state:
|
I didn't setup owncloud yet this time. Previous times I had a oc installed via web with only localhost in the array of trusted domains. |
Got it… On it… Nice catch!!! |
Due to a security hardening in 8.1 a missing value of empty trusted domains in the config would provoke an error as this was misused by a lot of users. This caused a problem where the initial installation happened from another domain than 127.0.0.1 as in this case the domain was considered untrusted as no value was defined. However, this special case should not get intercepted. To test: - [ ] Installing ownCloud on 127.0.0.1 works - [ ] Installing ownCloud on another domain / IP works - [ ] When setting up ownCloud from 127.0.0.1 and accessing it from the domain above the trusted domain error should be shown if not specified in the config Fixes #14320
That was a nasty one caused by a security hardening for 8.1. - Patch is at #14324 |
Reopening as still relevant based in https://stackoverflow.com/questions/37974876 not sure, though, if it's a collateral of #14332 (when the installation does not have access to said new trusted domain - like it happens when running ownCloud inside a container and trying to access via the host address) |
that button was removed because of sec reasons some time back -> close and bye-bye |
@DeepDiver1975 you're right; didn't see a7b2d12 - 👌 then |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Steps to reproduce
Having prepared an owncloud configuration:
Expected behaviour
Owncloud shows a "add to trusted domains" suggestion with a button that adds that ip to trusted domains.
Actual behaviour
Message and button are shown, but nothing happens after clicking the button.
Server configuration
Operating system:
Ubuntu 14.04 LTS
Web server:
Apache
Database:
MySQL
PHP version:
5.5.9
ownCloud version: (see ownCloud admin page)
"version":"8.0.0.9,"versionstring":"8.0","edition":"Community"
Updated from an older ownCloud or fresh install:
fresh
List of activated apps:
none
The content of config/config.php:
Are you using external storage, if yes which one: local/smb/sftp/...
no
Are you using encryption: no
Client configuration
Chrome, Firefox.
The text was updated successfully, but these errors were encountered: