Check if instance is not yet installed

[LukasReschke]

Due to a security hardening in 8.1 a missing value of empty trusted domains in the config would provoke an error as this was misused by a lot of users.

This caused a problem where the initial installation happened from another domain than 127.0.0.1 as in this case the domain was considered untrusted as no value was defined. However, this special case should not get intercepted.

To test:

• Installing ownCloud on 127.0.0.1 works
• Installing ownCloud on another domain / IP works
• When setting up ownCloud from 127.0.0.1 and accessing it from the domain above the trusted domain error should be shown if not specified in the config

Fixes #14320

@SergioBertolinSG Please test

[ghost]

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/9693/
Test PASSed.

[SergioBertolinSG]

While opening the installation page from a domain != localhost, installation page is opened, good. But after that webpage not available appears and you can't enter owncloud.

Config file created after the installation:

<?php
$CONFIG = array (
  'instanceid' => 'oc0hqre4cl0z',
  'passwordsalt' => 'blahblah',
  'secret' => 'blahblah',
  'trusted_domains' => 
  array (
    0 => NULL,
  ),
  'datadirectory' => '/var/www/html/owncloud_fix14320/data',
  'overwrite.cli.url' => 'http:///owncloud_fix14320',
  'dbtype' => 'mysql',
  'version' => '8.0.0.9',
  'dbname' => '22222',
  'dbhost' => 'localhost',
  'dbtableprefix' => 'oc_',
  'dbuser' => 'oc_22222',
  'dbpassword' => 'blahblah',
  'installed' => true,
);

[LukasReschke]

Remark to myself: Always check if it shows more than the installer 🤦

Should be fixed…

[SergioBertolinSG]

Working fine, #14321 is fixed here.

In the third option I faced #14320, the button doesn't add the domain.
(When setting up ownCloud from 127.0.0.1 and accessing it from the domain above the trusted domain error should be shown if not specified in the config)

[LukasReschke]

In the third option I faced #14320, the button doesn't add the domain.
(When setting up ownCloud from 127.0.0.1 and accessing it from the domain above the trusted domain error should be shown if not specified in the config)

How are you accessing it? – The URL to add trusted domains is generated via the first trusted domain.

So if you setup ownCloud under "owncloud.com" and then access it via "mycloud.com" the link will point to "owncloud.com" and the instance has obviously to be accessible for that. In your case I suspect that the URL that is generated is not accessible, can you take a look at the source and tell me where the URL points to?

(Maybe it's pointing to localhost but you cannot reach it from the other machine…?)

[scrutinizer-notifier]

The inspection completed: 1 updated code elements

[SergioBertolinSG]

@LukasReschke Yes, totally right, that was my problem. Machine wasn't accesible from second domain. Maybe an error message would be interesting in that case?

[ghost]

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/9704/
Test PASSed.

[LukasReschke]

@LukasReschke Yes, totally right, that was my problem. Machine wasn't accesible from second domain. Maybe an error message would be interesting in that case?

Let me see if I can add some JS magic at this state. However a different issue, I created #14332 for this. Not high priority for me right now though.

[LukasReschke]

Another easy one to review.

@th3fallen Can I motivate you to test this and take a look at the changeset? 😄

[th3fallen]

changes seem good 👍