-
Notifications
You must be signed in to change notification settings - Fork 2.1k
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enc2] Infinite recursion in \OCA\Encryption\KeyManager::__construct() #15705
Comments
@schiesbn @PVince81 @th3fallen |
How to reproduce: remove the sharedkey and you will get the recursion. |
looks like we have to move that code out of ctor: https://github.com/owncloud/core/blob/master/apps/encryption/lib/keymanager.php#L133 |
@DeepDiver1975 how'd you trigger this? That method should not cause a reinit of the class... |
@th3fallen kill the sharedkey from the filesystem or delete the sharekey in the db |
derp guess i should read more thoroughly.... |
no recursion here.... i removed files, worked, removed db record, worked, and removed both with no issue... |
Cannot reproduce the issue, here are my steps on master (ae681f0):
This should deliver a broken file, which is expected. No recursion seen, only this:
|
The text was updated successfully, but these errors were encountered: