-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files are not visible on browser but are accessible through clicking links #15856
Comments
I can confirm I have the same issue but my install is on ubuntu 14.04 with the package of OC8.0 at the time from the open suse build system. Mine was not an upgrade but a clean installation. |
Did you guys disable "Share API" in the admin page ? If you wanted to disable sharing, then please also deactivate the "Sharing" app. |
I haven't disabled it. Sharing API is enabled and we use sharing. |
@kalletabur can you use the browser's DOM inspector on the white space to see if the elements exist there ? It could be some kind of weird rendering problem |
When looking at Elements under Chrome's developer tools it can be seen tha at some point all lines forward are created with some transparent class: <tr data-id="145572" data-type="file" data-size="25600" data-file="..." data-mime="application/msword" data-mtime="..." data-etag="..." data-permissions="27" data-share-permissions="19" class="appear transparent"> I also see 2 errors:
|
The transparent class is set on the rows to create an animation by removing it. @atroxix you too confirm that you didn't disable "Share API" in the admin page ? (because that's a known issue: #15186) Are you able to get the stack trace of that "toString" error ? (maybe with the debugger) |
BTW, Kalle was reporting my error, so I just took over debugging my system myself ;) So yes, haven't disabled "Share API". About "toString" error - you mean this?
|
@atroxix ok so the error happens here: https://github.com/owncloud/core/blob/v8.0.2/apps/files_sharing/js/share.js#L164 I guess maybe the attribute "data-share-owner" is missing on some rows in the list. Does this stack appear when reloading the file list page (complete reload of the web page) ? Also, do you see any failing (red) calls in the network console ? |
The error does not appear right away after reload, but when I start scrolling (not even hovering over any of this empty area). Under Network I see 1 red line:
|
Would you guys mind posting the content of your "oc_appconfig" table ? Make sure to censor private data, if applicable. It might help to find out config variations which might help reproduce the issue. |
Here's the info from SQL dump (I hope I managed to get rid of all sensitive values there):
|
Okay, the things you guys have in common so far:
@atroxix I see you enforced expire date and link password (which is a nice thing 😉) and disabled reshares. Let me try this locally. |
Just noticed that @kalletabur has nginx. @atroxix how about you ? (just to find more common stuff) |
Kalle first created the issue on behalf of me, so we are speaking about the same issue ;) |
Ah! Good to know 😄 |
Still out of luck at the moment. I tried to replicate your sharing settings and also use LDAP users, but I cannot reproduce the issue. I tried with a long list of files where shared folders/files appear at the bottom of the list. Scrolling still works. Does this only happen for a specific user ? |
well, I also have encryption and the other apps enabled too, with the recovery key. |
@eagles051387 it would be helpful if you could also share more details. It could help to cross-reference the config with the one from @atroxix / @kalletabur to see what they have in common. Do you also have LDAP ? |
What's special about my user:
|
The difference then in my setup is im not using sharing as its my own On Thu, Apr 30, 2015 at 8:51 PM, Silver notifications@github.com wrote:
Jonathan Aquilina |
We discovered that when I change ordering to either by size or date then the files are shown. When I change it back to Name then the files are hidden again. |
That is really weird... |
Does it also happen if you share a folder with link and open the link in the browser ? |
|
Okay, I understand. How about you @eagles051387 ? |
@phaenomenon would it be possible for you to create such a folder with dummy files and share it with public link so I could have a look ? I cannot reproduce this locally and there isn't enough information yet to be able to fix it. |
This PR should make the list usable again #17341. If no one here is able to patch their system yet, we'll need to find another way to analyze the root cause. It is likely to be related to broken shares. |
Hah, I think that stack trace might contain a clue: #15856 (comment) |
Okay, we're getting closer. The screenshot from @phaenomenon shows that the "data-share-owner" attribute is missing on the file rows: #15856 (comment) I assume that you are the recipient of this shared folder ? |
This stack #15856 (comment) can only happen if the current user is not allowed to share at all but is still recipient of a shared folder from someone who is allowed to share. This means that all of you have set the special option "Exclude groups from sharing" in the admin page. Can you confirm ? I'll see if I can recreate the situation locally. |
Hey all, it works now!!! Thanks to PVince81 comment about the "shared folder" which pointed me to the right direction. Because I remember I didn't want to have my users SHARE stuff I had disabled that right after I initially installed Owncloud. So I just checked in the "Administration" settings. I had unchecked the option "Allow applications to use the share API" so this was NOT active. The administrator have no clue that such a setting would have such a massive effect in real. After I "checked" this setting (I have ticked only "Allow applications to use the share API" under Administration-->Sharing) it works fine and I see ALL folders. It would be nice if that could be fixed, at least, it should not be in relation to this setting because it's confusing. HTH, cheers |
@phaenomenon glad it fixed that for you, so the bug you had is this #15186 Unfortunately the other reporters here do have it enabled, so there might be yet another issue. |
I tried using the "Exclude groups from sharing" option but couldn't reproduce the original issue from @kalletabur and @atroxix. I'll try and dig into the code to find out when the "data-share-owner" attribute is missing. |
So far what we know:
|
I see here that the display name of the share owner would be read: https://github.com/owncloud/core/blob/v8.0.4/apps/files_sharing/lib/share/folder.php#L43 Now I see that if the display name would be empty or a value like "0", the attribute would not be set at all. @atroxix do you have a user called "0" ? Another guess is that LDAP doesn't return / doesn't contain any display name for the users ? It would explain the symptoms. |
AHA got it reproduced by creating a share at first, and the disallowing sharing for that group. |
Steps to reproduce
Expected resultList appears after scroll Actual resultThe list stops right before the file that was shared before the share interdiction. JS console says:
So basically there is a contradiction: the user still has an existing share but is now not allowed to share any more. |
Raised #17346 for the issue about stray "forbidden" shares. I'll provide a quickfix to make sure the JS code isn't confused by such situations. |
Quickfix here: #17349 |
That quickfix indeed fixes my issue at least on our test server with OwnCloud 8.0.2. |
It seems the same root cause also causes the sync client in other computers to fail synchronization. Is there any other issue about this? |
Not that I'm aware of. The JS fix wouldn't help with this. |
OK: #17444 |
@atroxix thanks a lot |
Steps to reproduce
Don't know how to reproduce. This appeared already in 7.0.4 version. Now we upgraded to 8.0.2 but the problem is still there
Expected behaviour
Browsing ownCloud files over web interface should show all the files.
Actual behaviour
Lot of files are not visible when browsing one web folder. At the beginning of the folder there are lots of folders and files visible, then there is lot of empty space and in the end there is like one file visible again. When hovering over empty space links are shown in URL bar - if you click on link of this file the file can be downloaded.
Server configuration
Operating system:
Debian 7.8
Web server:
NGINX (1.2.1-2.2)
Database:
MySQL (5.5.43-0)
PHP version:
PHP (5.4.4-14)
ownCloud version:
ownCloud 8.0.2 (stable)
Updated from an older ownCloud or fresh install:
Updated
List of activated apps:
Activity, Deleted files, External storage support, First Run Wizard, LDAP user and group backend, Mail Template Editor, PDF Viewer, Pictures, Server-side Encryption, Share Files, Text Editor, Versions, Video Viewer
The content of config/config.php:
Are you using external storage, if yes which one: local/smb/sftp/...
owncloud
Are you using encryption: yes/no
yes
Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
AD
LDAP configuration (delete this part if not used)
Client configuration
Browser:
Any (chrome, ff, opera)
Operating system:
OpenSUSE 13.2 64-bit
Logs
Web server error log
Adding log entries a about this directory
ownCloud log (data/owncloud.log)
I'm adding log entries that have related to one file that is not visible but through link the file is accessible
The text was updated successfully, but these errors were encountered: