&run does not work with all hooks anymore since refactoring

[LukasReschke]

Regression since a longer time, as described at #16750 (comment):

\OCP\Util::connectHook('OC_User', 'pre_createUser', '\OCA\MyApp\MyClass', 'createUser');

And in MyClass do something like:

<?php

namespace \OCA\MyApp;

class MyClass {
    public function createUser(&$params) {
        // Stop running – that should suffice…
        $params['run'] = false;
        // FIXME: Huge hack around a bug…
        exit();
    }
}

Option 1: Fix it.
Option 2: Fix the documentation in the user class.

Thoughts?

[PVince81]

The problem might be in the code that invokes the hook.
If that code ignores the value of "run", then the code flow will continue.

This is not an issue specific to the hook system, but rather to the hook caller.

Need to dig into the users code.

[PVince81]

Ok problem is here:

core/lib/private/server.php

Line 159 in 446f628

\OC_Hook::emit('OC_User', 'pre_createUser', array('run' => true, 'uid' => $uid, 'password' => $password));

"run" is always true.

But even if we passed by reference, the other "new" hook system doesn't have a way to cancel the hook AFAIK. @icewind1991 what do you think ?

[LukasReschke]

But even if we passed by reference, the other "new" hook system doesn't have a way to cancel the hook AFAIK. @icewind1991 what do you think ?

So basically this also affects all the other hooks below as well and we're doomed anyways? 🙈

[icewind1991]

Option 2: Fix the documentation in the user class.

imo having hooks cancel the operation was a terrible design decision

[PVince81]

Any update ? Fixing the documentation might be safer...

[ghost]

#16908 (comment) maybe, but we are where we are for now. @carlaschroder document?

[carlaschroder]

I'm happy to proofread, but this looks like something a real developer needs to write.

[ghost]

@PVince81 @LukasReschke suggestions?