Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE8 issue with gs-sharejs #18011

Closed
DeepDiver1975 opened this issue Jul 31, 2015 · 4 comments · Fixed by #18554
Closed

IE8 issue with gs-sharejs #18011

DeepDiver1975 opened this issue Jul 31, 2015 · 4 comments · Fixed by #18554
Assignees
@DeepDiver1975
Labels
feature:sharing Type:Bug
Milestone
8.2

Comments

@DeepDiver1975
Copy link
Member 

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0)
Timestamp: Fri, 31 Jul 2015 14:43:27 UTC


Message: Object doesn't support this property or method
Line: 6
Char: 1
Code: 0
URI: http://alien.fritz.box:8080/apps/files_sharing/js/3rdparty/gs-share/gs-share.js?v=b02269f5bca3c4c7370dce5296c8c557
@DeepDiver1975 DeepDiver1975 added this to the 8.1.2-next-maintenance milestone Jul 31, 2015
@DeepDiver1975 DeepDiver1975 mentioned this issue Jul 31, 2015
Closed
@PVince81
Copy link
Contributor

Seems this was introduced for the social share icons.

CC @schiesbn

@DeepDiver1975 DeepDiver1975 self-assigned this Jul 31, 2015
@PVince81
Copy link
Contributor

@DeepDiver1975 do you still intend to have a look at this ?

@DeepDiver1975
Copy link
Member Author

We this requires update of the 3rdparty lib.

@DeepDiver1975
Copy link
Member Author

afaik I had a branch somewhere ....

DeepDiver1975 added a commit that referenced this issue Aug 25, 2015
@DeepDiver1975
Simply hide sharing buttons for IE8 - fixes #18011
fcde023
@DeepDiver1975 DeepDiver1975 mentioned this issue Aug 25, 2015
Merged
DeepDiver1975 added a commit that referenced this issue Aug 25, 2015
@DeepDiver1975
Simply hide sharing buttons for IE8 - fixes #18011
b2adf17
@DeepDiver1975 DeepDiver1975 mentioned this issue Aug 25, 2015
Merged
@MorrisJobke MorrisJobke modified the milestones: 8.2-current, 8.1.2-current-maintenance Aug 25, 2015
MorrisJobke added a commit that referenced this issue Aug 25, 2015
@MorrisJobke
Merge pull request #18555 from owncloud/fix-gs-share-stable8.1
d2c81fd 
[stable8.1] Simply hide sharing buttons for IE8 - fixes #18011
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DeepDiver1975 DeepDiver1975

Labels
feature:sharing Type:Bug
Projects
None yet
Milestone
8.2
Development

Successfully merging a pull request may close this issue.

Simply hide sharing buttons for IE8 owncloud/core
3 participants
@MorrisJobke @PVince81 @DeepDiver1975