Owncloud 8.2.2.2 breaks support for OneNote 2013

[brandonkirsch]

I just upgraded through each major release of OwnCloud since 7.0 and my Windows 7 OneNote 2013 client quit working when I finally reached 8.2.2.2.

I used mod_dumpio to capture the HTTPS traffic and I see 4 unique requests. 2 HEAD requests, 1 PROPFIND request and finally a LOCK request where the error occurs. The LOCK request:

---

LOCK /owncloud/remote.php/webdav/Consulting/Personal/Personal.one HTTP/1.1
Cache-Control: no-cache
Connection: Keep-Alive
Pragma: no-cache
Content-Type: text/xml; charset="utf-8"
User-Agent: Microsoft Office OneNote 2013
Translate: f
Timeout: Second-60
X-IDCRL_ACCEPTED: t
Content-Length: 202
Host: brandonkirsch.com
Authorization: Basic Yxxxxxxxxxxxxxxxxxxxxxxxh
Cookie: oc10490278c2=3xxxxxxxxxxxxxxxxx1; oc_sessionPassphrase=txxxxxxxxxxxxxxC

<?xml version="1.0" encoding="utf-8" ?><D:lockinfo xmlns:D="DAV:"><D:lockscope><D:exclusive/></D:lockscope><D:locktype><D:write/></D:locktype><D:owner><D:href>MIS\bkirsch</D:href></D:owner></D:lockinfo>

---

When OneNote 2013 requests a LOCK, Owncloud responds with the following error:

HTTP/1.1 501 Not Implemented
Date: Tue, 26 Jan 2016 15:21:19 GMT
Server: Apache/2.2.15 (CentOS)
X-Powered-By: PHP/5.5.31
Expires: Thu, 19 Nov 1981 08:52:00 GMT
Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0
Pragma: no-cache
Content-Security-Policy: default-src 'self'; script-src 'self' 'unsafe-eval'; style-src 'self' 'unsafe-inline'; frame-src *; img-src * data: blob:; font-src 'self' data:; media-src *; connect-src *
X-Content-Type-Options: nosniff
X-XSS-Protection: 1; mode=block
X-Robots-Tag: none
X-Frame-Options: SAMEORIGIN
Content-Length: 247
Connection: close
Content-Type: application/xml; charset=utf-8


<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\\DAV\\Exception\\NotImplemented</s:exception>
  <s:message>There was no handler found for this "LOCK" method</s:message>
</d:error>

...and my OneNote Notebook fails to sync.

This was not the case in Owncloud 8.0.latest or 8.1.latest during my upgrade process, only failing once I reached 8.2.2.2.

I believe this issue may be related to: #17732

[LukasReschke]

Probably requires whitelisting OneNote 2013 as well at

core/apps/dav/lib/server.php

Lines 99 to 103 in aa598fc

	// Finder on OS X requires Class 2 WebDAV support (locking), since we do
	// not provide locking we emulate it using a fake locking plugin.
	if($request->isUserAgent(['/WebDAVFS/'])) {
	$this->server->addPlugin(new \OCA\DAV\Connector\Sabre\FakeLockerPlugin());
	}

, let me create a PR for you to test.

[LukasReschke]

Patch is at #21926, please test.

[brandonkirsch]

Fixed it!

I worry the patch may be a little overly specific (OneNote 2010 is still popular, although I don't have a copy to test with) but I am back in action.

Thanks for the ridiculously quick fix!

[stribog]

OneNote 2013, I'm using (v15.0.4805.1000) using two "user-agents"=>"Microsoft Office OneNote 2013" and "OneNote/15.0.4805.1000 (Windows/xx; Desktop WOW64; en-US; Desktop app; Vendor/Computer Model)".
I don't know if it was always like that or changed recently.
It prevents from OwnCloud users to change some items that were already created.
I fixed it in my instance of OwnCloud by adding another user agent in Server.php and ServerFactory.php
It looks like that;
if($request->isUserAgent([
'/WebDAVFS/',
'/Microsoft Office OneNote 2013/',

•                 '/OneNote/',
  ])) {
  

I propose to make similar change in the running change log

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.